Skip to content

Commit 21a2960

Browse files
rwk-gitLorenzo Pieralisi
authored andcommitted
dt-bindings: PCI: Update the RK3399 example to a valid one
Update the example in the documentation to a valid example. Address for mem-base was invalid, it pointed to address 0x8000'0000 which is the upper region of the DDR which is not necessarily populated depending on the board. This address should point to the base of the memory window region of the controller which is 0xfa00'0000. Add missing pinctrl. Link: https://lore.kernel.org/r/20230418074700.1083505-7-rick.wertenbroek@gmail.com Signed-off-by: Rick Wertenbroek <rick.wertenbroek@gmail.com> Signed-off-by: Lorenzo Pieralisi <lpieralisi@kernel.org> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
1 parent 9dd3c7c commit 21a2960

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

Documentation/devicetree/bindings/pci/rockchip,rk3399-pcie-ep.yaml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ examples:
4747
4848
pcie-ep@f8000000 {
4949
compatible = "rockchip,rk3399-pcie-ep";
50-
reg = <0x0 0xfd000000 0x0 0x1000000>, <0x0 0x80000000 0x0 0x20000>;
50+
reg = <0x0 0xfd000000 0x0 0x1000000>, <0x0 0xfa000000 0x0 0x2000000>;
5151
reg-names = "apb-base", "mem-base";
5252
clocks = <&cru ACLK_PCIE>, <&cru ACLK_PERF_PCIE>,
5353
<&cru PCLK_PCIE>, <&cru SCLK_PCIE_PM>;
@@ -63,6 +63,8 @@ examples:
6363
phys = <&pcie_phy 0>, <&pcie_phy 1>, <&pcie_phy 2>, <&pcie_phy 3>;
6464
phy-names = "pcie-phy-0", "pcie-phy-1", "pcie-phy-2", "pcie-phy-3";
6565
rockchip,max-outbound-regions = <16>;
66+
pinctrl-names = "default";
67+
pinctrl-0 = <&pcie_clkreqnb_cpm>;
6668
};
6769
};
6870
...

0 commit comments

Comments
 (0)