Skip to content

Commit 20f7a0d

Browse files
committed
clk: mediatek: fix unregister function in mtk_clk_register_dividers cleanup
When the cleanup paths for the various clk register APIs in the MediaTek clk library were added, the one in the dividers type used the wrong type of unregister function. This would result in incorrect dereferencing of the clk pointer and freeing of invalid pointers. Fix this by switching to the correct type of clk unregistration call. Fixes: 3c3ba2a ("clk: mediatek: mtk: Implement error handling in register APIs") Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Link: https://lore.kernel.org/r/20220926102523.2367530-2-wenst@chromium.org Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
1 parent 116151b commit 20f7a0d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/clk/mediatek/clk-mtk.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -393,7 +393,7 @@ int mtk_clk_register_dividers(const struct mtk_clk_divider *mcds, int num,
393393
if (IS_ERR_OR_NULL(clk_data->hws[mcd->id]))
394394
continue;
395395

396-
mtk_clk_unregister_composite(clk_data->hws[mcd->id]);
396+
clk_hw_unregister_divider(clk_data->hws[mcd->id]);
397397
clk_data->hws[mcd->id] = ERR_PTR(-ENOENT);
398398
}
399399

0 commit comments

Comments
 (0)