Skip to content

Commit 203ce39

Browse files
wensbebarino
authored andcommitted
clk: mediatek: mux: Reverse check for existing clk to reduce nesting level
The clk registration code here currently does: if (IS_ERR_OR_NULL(clk_data->clks[mux->id])) { ... do clk registration ... } This extra level of nesting wastes screen real estate. Reduce the nesting level by reversing the conditional shown above. Other than that, functionality is not changed. Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> Reviewed-by: Miles Chen <miles.chen@mediatek.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Link: https://lore.kernel.org/r/20220208124034.414635-24-wenst@chromium.org Reviewed-by: Chun-Jie Chen <chun-jie.chen@mediatek.com> Signed-off-by: Stephen Boyd <sboyd@kernel.org>
1 parent e938a13 commit 203ce39

File tree

1 file changed

+8
-7
lines changed

1 file changed

+8
-7
lines changed

drivers/clk/mediatek/clk-mux.c

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -208,16 +208,17 @@ int mtk_clk_register_muxes(const struct mtk_mux *muxes,
208208
for (i = 0; i < num; i++) {
209209
const struct mtk_mux *mux = &muxes[i];
210210

211-
if (IS_ERR_OR_NULL(clk_data->clks[mux->id])) {
212-
clk = mtk_clk_register_mux(mux, regmap, lock);
211+
if (!IS_ERR_OR_NULL(clk_data->clks[mux->id]))
212+
continue;
213213

214-
if (IS_ERR(clk)) {
215-
pr_err("Failed to register clk %s: %pe\n", mux->name, clk);
216-
continue;
217-
}
214+
clk = mtk_clk_register_mux(mux, regmap, lock);
218215

219-
clk_data->clks[mux->id] = clk;
216+
if (IS_ERR(clk)) {
217+
pr_err("Failed to register clk %s: %pe\n", mux->name, clk);
218+
continue;
220219
}
220+
221+
clk_data->clks[mux->id] = clk;
221222
}
222223

223224
return 0;

0 commit comments

Comments
 (0)