Skip to content

Commit 2002eb6

Browse files
jnikularodrigovivi
authored andcommitted
drm/i915/sdvo: fix panel_type initialization
Commit 3f9ffce ("drm/i915: Do panel VBT init early if the VBT declares an explicit panel type") started using -1 as the value for unset panel_type. It gets initialized in intel_panel_init_alloc(), but the SDVO code never calls it. Call intel_panel_init_alloc() to initialize the panel, including the panel_type. Reported-by: Tomi Leppänen <tomi@tomin.site> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/8896 Fixes: 3f9ffce ("drm/i915: Do panel VBT init early if the VBT declares an explicit panel type") Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: <stable@vger.kernel.org> # v6.1+ Reviewed-by: Uma Shankar <uma.shankar@intel.com> Tested-by: Tomi Leppänen <tomi@tomin.site> Signed-off-by: Jani Nikula <jani.nikula@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20230803122706.838721-1-jani.nikula@intel.com (cherry picked from commit 26e6029) Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
1 parent 5598c9b commit 2002eb6

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/gpu/drm/i915/display/intel_sdvo.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2752,7 +2752,7 @@ static struct intel_sdvo_connector *intel_sdvo_connector_alloc(void)
27522752
__drm_atomic_helper_connector_reset(&sdvo_connector->base.base,
27532753
&conn_state->base.base);
27542754

2755-
INIT_LIST_HEAD(&sdvo_connector->base.panel.fixed_modes);
2755+
intel_panel_init_alloc(&sdvo_connector->base);
27562756

27572757
return sdvo_connector;
27582758
}

0 commit comments

Comments
 (0)