Skip to content

Commit 1f92a84

Browse files
Thomas Zimmermannmpe
authored andcommitted
powerpc: Remove file parameter from phys_mem_access_prot()
Remove 'file' parameter from struct machdep_calls.phys_mem_access_prot and its implementation in pci_phys_mem_access_prot(). The file is not used on PowerPC. By removing it, a later patch can simplify fbdev's mmap code, which uses phys_mem_access_prot() on PowerPC. Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Reviewed-by: Arnd Bergmann <arnd@arndb.de> [mpe: Rebase on unrelated changes to phys_mem_access_prot()] Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> Link: https://msgid.link/20230922080636.26762-5-tzimmermann@suse.de
1 parent 322948c commit 1f92a84

File tree

5 files changed

+15
-13
lines changed

5 files changed

+15
-13
lines changed

arch/powerpc/include/asm/machdep.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -106,8 +106,7 @@ struct machdep_calls {
106106
int (*pci_get_legacy_ide_irq)(struct pci_dev *dev, int channel);
107107

108108
/* Get access protection for /dev/mem */
109-
pgprot_t (*phys_mem_access_prot)(struct file *file,
110-
unsigned long pfn,
109+
pgprot_t (*phys_mem_access_prot)(unsigned long pfn,
111110
unsigned long size,
112111
pgprot_t vma_prot);
113112

arch/powerpc/include/asm/pci.h

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -105,9 +105,7 @@ extern void of_scan_pci_bridge(struct pci_dev *dev);
105105
extern void of_scan_bus(struct device_node *node, struct pci_bus *bus);
106106
extern void of_rescan_bus(struct device_node *node, struct pci_bus *bus);
107107

108-
struct file;
109-
extern pgprot_t pci_phys_mem_access_prot(struct file *file,
110-
unsigned long pfn,
108+
extern pgprot_t pci_phys_mem_access_prot(unsigned long pfn,
111109
unsigned long size,
112110
pgprot_t prot);
113111

arch/powerpc/include/asm/pgtable.h

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -120,9 +120,15 @@ static inline void mark_initmem_nx(void) { }
120120
int ptep_set_access_flags(struct vm_area_struct *vma, unsigned long address,
121121
pte_t *ptep, pte_t entry, int dirty);
122122

123+
pgprot_t __phys_mem_access_prot(unsigned long pfn, unsigned long size,
124+
pgprot_t vma_prot);
125+
123126
struct file;
124-
pgprot_t phys_mem_access_prot(struct file *file, unsigned long pfn,
125-
unsigned long size, pgprot_t vma_prot);
127+
static inline pgprot_t phys_mem_access_prot(struct file *file, unsigned long pfn,
128+
unsigned long size, pgprot_t vma_prot)
129+
{
130+
return __phys_mem_access_prot(pfn, size, vma_prot);
131+
}
126132
#define __HAVE_PHYS_MEM_ACCESS_PROT
127133

128134
void __update_mmu_cache(struct vm_area_struct *vma, unsigned long address, pte_t *ptep);

arch/powerpc/kernel/pci-common.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -521,8 +521,7 @@ int pci_iobar_pfn(struct pci_dev *pdev, int bar, struct vm_area_struct *vma)
521521
* PCI device, it tries to find the PCI device first and calls the
522522
* above routine
523523
*/
524-
pgprot_t pci_phys_mem_access_prot(struct file *file,
525-
unsigned long pfn,
524+
pgprot_t pci_phys_mem_access_prot(unsigned long pfn,
526525
unsigned long size,
527526
pgprot_t prot)
528527
{

arch/powerpc/mm/mem.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,18 +35,18 @@ unsigned long long memory_limit;
3535
unsigned long empty_zero_page[PAGE_SIZE / sizeof(unsigned long)] __page_aligned_bss;
3636
EXPORT_SYMBOL(empty_zero_page);
3737

38-
pgprot_t phys_mem_access_prot(struct file *file, unsigned long pfn,
39-
unsigned long size, pgprot_t vma_prot)
38+
pgprot_t __phys_mem_access_prot(unsigned long pfn, unsigned long size,
39+
pgprot_t vma_prot)
4040
{
4141
if (ppc_md.phys_mem_access_prot)
42-
return ppc_md.phys_mem_access_prot(file, pfn, size, vma_prot);
42+
return ppc_md.phys_mem_access_prot(pfn, size, vma_prot);
4343

4444
if (!page_is_ram(pfn))
4545
vma_prot = pgprot_noncached(vma_prot);
4646

4747
return vma_prot;
4848
}
49-
EXPORT_SYMBOL(phys_mem_access_prot);
49+
EXPORT_SYMBOL(__phys_mem_access_prot);
5050

5151
#ifdef CONFIG_MEMORY_HOTPLUG
5252
static DEFINE_MUTEX(linear_mapping_mutex);

0 commit comments

Comments
 (0)