Skip to content

Commit 1f56643

Browse files
jwrdegoedebroonie
authored andcommitted
ASoC: lower "no backend DAIs enabled for ... Port" log severity
If SNDRV_PCM_IOCTL_PREPARE is called when the mixer settings linking frontend and backend have not been setup yet this results in e.g. the following errors getting logged: [ 43.244549] Baytrail Audio Port: ASoC: no backend DAIs enabled for Baytrail Audio Port [ 43.244744] Baytrail Audio Port: ASoC: error at dpcm_fe_dai_prepare on Baytrail Audio Port: -22 pipewire triggers this leading to 96 lines getting logged after the user has logged into a GNOME session. Change the actual "no backend DAIs enabled for ... Port" error to dev_err_once() to avoid it getting repeated 48 times. While at it also improve the error by hinting the user how to fix this. To not make developing new UCM profiles harder, also log the error at dev_dbg() level all the time (vs once). So that e.g. dyndbg can be used to (re)enable the messages. Also changes _soc_pcm_ret() to not log for -EINVAL errors, to fix the other error getting logged 48 times. Userspace passing wrong parameters should not lead to dmesg messages. Link: https://gitlab.freedesktop.org/pipewire/pipewire/-/issues/3407 Signed-off-by: Hans de Goede <hdegoede@redhat.com> Link: https://lore.kernel.org/r/20230805171435.31696-1-hdegoede@redhat.com Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent c163108 commit 1f56643

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

sound/soc/soc-pcm.c

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ static inline int _soc_pcm_ret(struct snd_soc_pcm_runtime *rtd,
3838
switch (ret) {
3939
case -EPROBE_DEFER:
4040
case -ENOTSUPP:
41+
case -EINVAL:
4142
break;
4243
default:
4344
dev_err(rtd->dev,
@@ -2466,8 +2467,11 @@ static int dpcm_fe_dai_prepare(struct snd_pcm_substream *substream)
24662467

24672468
/* there is no point preparing this FE if there are no BEs */
24682469
if (list_empty(&fe->dpcm[stream].be_clients)) {
2469-
dev_err(fe->dev, "ASoC: no backend DAIs enabled for %s\n",
2470-
fe->dai_link->name);
2470+
/* dev_err_once() for visibility, dev_dbg() for debugging UCM profiles */
2471+
dev_err_once(fe->dev, "ASoC: no backend DAIs enabled for %s, possibly missing ALSA mixer-based routing or UCM profile\n",
2472+
fe->dai_link->name);
2473+
dev_dbg(fe->dev, "ASoC: no backend DAIs enabled for %s\n",
2474+
fe->dai_link->name);
24712475
ret = -EINVAL;
24722476
goto out;
24732477
}

0 commit comments

Comments
 (0)