Skip to content

Commit 1ec0952

Browse files
committed
PCI: Simplify pci_dev_driver()
Simplify pci_dev_driver() by removing the "else". The "if" case always returns, so the "else" is superfluous. No functional change intended. Link: https://lore.kernel.org/r/20230824193712.542167-9-helgaas@kernel.org Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
1 parent 3b59ca9 commit 1ec0952

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

drivers/pci/pci-driver.c

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1474,14 +1474,15 @@ static struct pci_driver pci_compat_driver = {
14741474
*/
14751475
struct pci_driver *pci_dev_driver(const struct pci_dev *dev)
14761476
{
1477+
int i;
1478+
14771479
if (dev->driver)
14781480
return dev->driver;
1479-
else {
1480-
int i;
1481-
for (i = 0; i <= PCI_ROM_RESOURCE; i++)
1482-
if (dev->resource[i].flags & IORESOURCE_BUSY)
1483-
return &pci_compat_driver;
1484-
}
1481+
1482+
for (i = 0; i <= PCI_ROM_RESOURCE; i++)
1483+
if (dev->resource[i].flags & IORESOURCE_BUSY)
1484+
return &pci_compat_driver;
1485+
14851486
return NULL;
14861487
}
14871488
EXPORT_SYMBOL(pci_dev_driver);

0 commit comments

Comments
 (0)