Skip to content

Commit 1e52550

Browse files
tlendackybp3tk0v
authored andcommitted
x86/sev: Shorten struct name snp_secrets_page_layout to snp_secrets_page
Ending a struct name with "layout" is a little redundant, so shorten the snp_secrets_page_layout name to just snp_secrets_page. No functional change. [ bp: Rename the local pointer to "secrets" too for more clarity. ] Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com> Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de> Link: https://lore.kernel.org/r/bc8d58302c6ab66c3beeab50cce3ec2c6bd72d6c.1713974291.git.thomas.lendacky@amd.com
1 parent ed30a4a commit 1e52550

File tree

3 files changed

+18
-18
lines changed

3 files changed

+18
-18
lines changed

arch/x86/include/asm/sev.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ struct secrets_os_area {
140140
#define VMPCK_KEY_LEN 32
141141

142142
/* See the SNP spec version 0.9 for secrets page format */
143-
struct snp_secrets_page_layout {
143+
struct snp_secrets_page {
144144
u32 version;
145145
u32 imien : 1,
146146
rsvd1 : 31;

arch/x86/kernel/sev.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -648,7 +648,7 @@ static u64 __init get_secrets_page(void)
648648

649649
static u64 __init get_snp_jump_table_addr(void)
650650
{
651-
struct snp_secrets_page_layout *layout;
651+
struct snp_secrets_page *secrets;
652652
void __iomem *mem;
653653
u64 pa, addr;
654654

@@ -662,9 +662,9 @@ static u64 __init get_snp_jump_table_addr(void)
662662
return 0;
663663
}
664664

665-
layout = (__force struct snp_secrets_page_layout *)mem;
665+
secrets = (__force struct snp_secrets_page *)mem;
666666

667-
addr = layout->os_area.ap_jump_table_pa;
667+
addr = secrets->os_area.ap_jump_table_pa;
668668
iounmap(mem);
669669

670670
return addr;

drivers/virt/coco/sev-guest/sev-guest.c

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ struct snp_guest_dev {
5959
*/
6060
struct snp_guest_msg secret_request, secret_response;
6161

62-
struct snp_secrets_page_layout *layout;
62+
struct snp_secrets_page *secrets;
6363
struct snp_req_data input;
6464
union {
6565
struct snp_report_req report;
@@ -743,26 +743,26 @@ static const struct file_operations snp_guest_fops = {
743743
.unlocked_ioctl = snp_guest_ioctl,
744744
};
745745

746-
static u8 *get_vmpck(int id, struct snp_secrets_page_layout *layout, u32 **seqno)
746+
static u8 *get_vmpck(int id, struct snp_secrets_page *secrets, u32 **seqno)
747747
{
748748
u8 *key = NULL;
749749

750750
switch (id) {
751751
case 0:
752-
*seqno = &layout->os_area.msg_seqno_0;
753-
key = layout->vmpck0;
752+
*seqno = &secrets->os_area.msg_seqno_0;
753+
key = secrets->vmpck0;
754754
break;
755755
case 1:
756-
*seqno = &layout->os_area.msg_seqno_1;
757-
key = layout->vmpck1;
756+
*seqno = &secrets->os_area.msg_seqno_1;
757+
key = secrets->vmpck1;
758758
break;
759759
case 2:
760-
*seqno = &layout->os_area.msg_seqno_2;
761-
key = layout->vmpck2;
760+
*seqno = &secrets->os_area.msg_seqno_2;
761+
key = secrets->vmpck2;
762762
break;
763763
case 3:
764-
*seqno = &layout->os_area.msg_seqno_3;
765-
key = layout->vmpck3;
764+
*seqno = &secrets->os_area.msg_seqno_3;
765+
key = secrets->vmpck3;
766766
break;
767767
default:
768768
break;
@@ -897,8 +897,8 @@ static void unregister_sev_tsm(void *data)
897897

898898
static int __init sev_guest_probe(struct platform_device *pdev)
899899
{
900-
struct snp_secrets_page_layout *layout;
901900
struct sev_guest_platform_data *data;
901+
struct snp_secrets_page *secrets;
902902
struct device *dev = &pdev->dev;
903903
struct snp_guest_dev *snp_dev;
904904
struct miscdevice *misc;
@@ -916,15 +916,15 @@ static int __init sev_guest_probe(struct platform_device *pdev)
916916
if (!mapping)
917917
return -ENODEV;
918918

919-
layout = (__force void *)mapping;
919+
secrets = (__force void *)mapping;
920920

921921
ret = -ENOMEM;
922922
snp_dev = devm_kzalloc(&pdev->dev, sizeof(struct snp_guest_dev), GFP_KERNEL);
923923
if (!snp_dev)
924924
goto e_unmap;
925925

926926
ret = -EINVAL;
927-
snp_dev->vmpck = get_vmpck(vmpck_id, layout, &snp_dev->os_area_msg_seqno);
927+
snp_dev->vmpck = get_vmpck(vmpck_id, secrets, &snp_dev->os_area_msg_seqno);
928928
if (!snp_dev->vmpck) {
929929
dev_err(dev, "invalid vmpck id %d\n", vmpck_id);
930930
goto e_unmap;
@@ -938,7 +938,7 @@ static int __init sev_guest_probe(struct platform_device *pdev)
938938

939939
platform_set_drvdata(pdev, snp_dev);
940940
snp_dev->dev = dev;
941-
snp_dev->layout = layout;
941+
snp_dev->secrets = secrets;
942942

943943
/* Allocate the shared page used for the request and response message. */
944944
snp_dev->request = alloc_shared_pages(dev, sizeof(struct snp_guest_msg));

0 commit comments

Comments
 (0)