Skip to content

Commit 1d7ec62

Browse files
committed
clk: meson: meson8b: remove spinlock
The spinlock in meson8b clock controller is now only protecting a call to regmap_update_bits(). The regmap API already has its own locking system so this spinlock is redundant. Remove it. Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Link: https://lore.kernel.org/r/20240925-clk-meson8b-spinlock-v1-1-50b7f2d02d7d@baylibre.com [jbrunet: amended to remove unused variable as reported by lkp] Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
1 parent bbf7e40 commit 1d7ec62

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

drivers/clk/meson/meson8b.c

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,6 @@
2525
#include <dt-bindings/clock/meson8b-clkc.h>
2626
#include <dt-bindings/reset/amlogic,meson8b-clkc-reset.h>
2727

28-
static DEFINE_SPINLOCK(meson_clk_lock);
29-
3028
struct meson8b_clk_reset {
3129
struct reset_controller_dev reset;
3230
struct regmap *regmap;
@@ -3699,7 +3697,6 @@ static int meson8b_clk_reset_update(struct reset_controller_dev *rcdev,
36993697
container_of(rcdev, struct meson8b_clk_reset, reset);
37003698
const struct meson8b_clk_reset_line *reset;
37013699
unsigned int value = 0;
3702-
unsigned long flags;
37033700

37043701
if (id >= ARRAY_SIZE(meson8b_clk_reset_bits))
37053702
return -EINVAL;
@@ -3709,13 +3706,9 @@ static int meson8b_clk_reset_update(struct reset_controller_dev *rcdev,
37093706
if (assert != reset->active_low)
37103707
value = BIT(reset->bit_idx);
37113708

3712-
spin_lock_irqsave(&meson_clk_lock, flags);
3713-
37143709
regmap_update_bits(meson8b_clk_reset->regmap, reset->reg,
37153710
BIT(reset->bit_idx), value);
37163711

3717-
spin_unlock_irqrestore(&meson_clk_lock, flags);
3718-
37193712
return 0;
37203713
}
37213714

0 commit comments

Comments
 (0)