powerpc: 85xx: mark local functions static

arndb · mpe · commit 1c57b9f63ab3 · 2024-02-06T21:18:23.000+11:00
These functions are either used in only one file and can just be made static or need an #include statement to avoid a warning: arch/powerpc/platforms/85xx/mpc8536_ds.c:30:13: error: no previous prototype for 'mpc8536_ds_pic_init' [-Werror=missing-prototypes] arch/powerpc/platforms/85xx/p1010rdb.c:27:13: error: no previous prototype for 'p1010_rdb_pic_init' [-Werror=missing-prototypes] arch/powerpc/platforms/85xx/p1022_ds.c:373:6: error: no previous prototype for 'p1022ds_set_pixel_clock' [-Werror=missing-prototypes] arch/powerpc/platforms/85xx/p1022_ds.c:422:1: error: no previous prototype for 'p1022ds_valid_monitor_port' [-Werror=missing-prototypes] arch/powerpc/platforms/85xx/p1022_ds.c:435:13: error: no previous prototype for 'p1022_ds_pic_init' [-Werror=missing-prototypes] arch/powerpc/platforms/85xx/p1022_rdk.c:43:6: error: no previous prototype for 'p1022rdk_set_pixel_clock' [-Werror=missing-prototypes] arch/powerpc/platforms/85xx/p1022_rdk.c:92:1: error: no previous prototype for 'p1022rdk_valid_monitor_port' [-Werror=missing-prototypes] arch/powerpc/platforms/85xx/p1022_rdk.c:99:13: error: no previous prototype for 'p1022_rdk_pic_init' [-Werror=missing-prototypes] arch/powerpc/platforms/85xx/socrates_fpga_pic.c:273:13: error: no previous prototype for 'socrates_fpga_pic_init' [-Werror=missing-prototypes] arch/powerpc/platforms/85xx/xes_mpc85xx.c:40:13: error: no previous prototype for 'xes_mpc85xx_pic_init' [-Werror=missing-prototypes] arch/powerpc/platforms/85xx/mvme2500.c:24:13: error: no previous prototype for 'mvme2500_pic_init' [-Werror=missing-prototypes] Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> Link: https://msgid.link/20240123125148.2004648-2-arnd@kernel.org
diff --git a/arch/powerpc/platforms/85xx/mpc8536_ds.c b/arch/powerpc/platforms/85xx/mpc8536_ds.c
@@ -27,7 +27,7 @@
 
 #include "mpc85xx.h"
 
-void __init mpc8536_ds_pic_init(void)
+static void __init mpc8536_ds_pic_init(void)
 {
 	struct mpic *mpic = mpic_alloc(NULL, 0, MPIC_BIG_ENDIAN,
 			0, 256, " OpenPIC  ");
diff --git a/arch/powerpc/platforms/85xx/mvme2500.c b/arch/powerpc/platforms/85xx/mvme2500.c
@@ -21,7 +21,7 @@
 
 #include "mpc85xx.h"
 
-void __init mvme2500_pic_init(void)
+static void __init mvme2500_pic_init(void)
 {
 	struct mpic *mpic = mpic_alloc(NULL, 0,
 		  MPIC_BIG_ENDIAN | MPIC_SINGLE_DEST_CPU,
diff --git a/arch/powerpc/platforms/85xx/p1010rdb.c b/arch/powerpc/platforms/85xx/p1010rdb.c
@@ -24,7 +24,7 @@
 
 #include "mpc85xx.h"
 
-void __init p1010_rdb_pic_init(void)
+static void __init p1010_rdb_pic_init(void)
 {
 	struct mpic *mpic = mpic_alloc(NULL, 0, MPIC_BIG_ENDIAN |
 	  MPIC_SINGLE_DEST_CPU,
diff --git a/arch/powerpc/platforms/85xx/p1022_ds.c b/arch/powerpc/platforms/85xx/p1022_ds.c
@@ -370,7 +370,7 @@ static void p1022ds_set_monitor_port(enum fsl_diu_monitor_port port)
  *
  * @pixclock: the wavelength, in picoseconds, of the clock
  */
-void p1022ds_set_pixel_clock(unsigned int pixclock)
+static void p1022ds_set_pixel_clock(unsigned int pixclock)
 {
 	struct device_node *guts_np = NULL;
 	struct ccsr_guts __iomem *guts;
@@ -418,7 +418,7 @@ void p1022ds_set_pixel_clock(unsigned int pixclock)
 /**
  * p1022ds_valid_monitor_port: set the monitor port for sysfs
  */
-enum fsl_diu_monitor_port
+static enum fsl_diu_monitor_port
 p1022ds_valid_monitor_port(enum fsl_diu_monitor_port port)
 {
 	switch (port) {
@@ -432,7 +432,7 @@ p1022ds_valid_monitor_port(enum fsl_diu_monitor_port port)
 
 #endif
 
-void __init p1022_ds_pic_init(void)
+static void __init p1022_ds_pic_init(void)
 {
 	struct mpic *mpic = mpic_alloc(NULL, 0, MPIC_BIG_ENDIAN |
 		MPIC_SINGLE_DEST_CPU,
diff --git a/arch/powerpc/platforms/85xx/p1022_rdk.c b/arch/powerpc/platforms/85xx/p1022_rdk.c
@@ -40,7 +40,7 @@
  *
  * @pixclock: the wavelength, in picoseconds, of the clock
  */
-void p1022rdk_set_pixel_clock(unsigned int pixclock)
+static void p1022rdk_set_pixel_clock(unsigned int pixclock)
 {
 	struct device_node *guts_np = NULL;
 	struct ccsr_guts __iomem *guts;
@@ -88,15 +88,15 @@ void p1022rdk_set_pixel_clock(unsigned int pixclock)
 /**
  * p1022rdk_valid_monitor_port: set the monitor port for sysfs
  */
-enum fsl_diu_monitor_port
+static enum fsl_diu_monitor_port
 p1022rdk_valid_monitor_port(enum fsl_diu_monitor_port port)
 {
 	return FSL_DIU_PORT_DVI;
 }
 
 #endif
 
-void __init p1022_rdk_pic_init(void)
+static void __init p1022_rdk_pic_init(void)
 {
 	struct mpic *mpic = mpic_alloc(NULL, 0, MPIC_BIG_ENDIAN |
 		MPIC_SINGLE_DEST_CPU,
diff --git a/arch/powerpc/platforms/85xx/socrates_fpga_pic.c b/arch/powerpc/platforms/85xx/socrates_fpga_pic.c
@@ -8,6 +8,8 @@
 #include <linux/of_irq.h>
 #include <linux/io.h>
 
+#include "socrates_fpga_pic.h"
+
 /*
  * The FPGA supports 9 interrupt sources, which can be routed to 3
  * interrupt request lines of the MPIC. The line to be used can be
diff --git a/arch/powerpc/platforms/85xx/xes_mpc85xx.c b/arch/powerpc/platforms/85xx/xes_mpc85xx.c
@@ -37,7 +37,7 @@
 #define MPC85xx_L2CTL_L2I		0x40000000 /* L2 flash invalidate */
 #define MPC85xx_L2CTL_L2SIZ_MASK	0x30000000 /* L2 SRAM size (R/O) */
 
-void __init xes_mpc85xx_pic_init(void)
+static void __init xes_mpc85xx_pic_init(void)
 {
 	struct mpic *mpic = mpic_alloc(NULL, 0, MPIC_BIG_ENDIAN,
 			0, 256, " OpenPIC  ");

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@`
`27`	`27`
`28`	`28`	`#include "mpc85xx.h"`
`29`	`29`
`30`		`-void __init mpc8536_ds_pic_init(void)`
	`30`	`+static void __init mpc8536_ds_pic_init(void)`
`31`	`31`	`{`
`32`	`32`	`struct mpic *mpic = mpic_alloc(NULL, 0, MPIC_BIG_ENDIAN,`
`33`	`33`	`0, 256, " OpenPIC ");`
Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@`
`21`	`21`
`22`	`22`	`#include "mpc85xx.h"`
`23`	`23`
`24`		`-void __init mvme2500_pic_init(void)`
	`24`	`+static void __init mvme2500_pic_init(void)`
`25`	`25`	`{`
`26`	`26`	`struct mpic *mpic = mpic_alloc(NULL, 0,`
`27`	`27`	`MPIC_BIG_ENDIAN \| MPIC_SINGLE_DEST_CPU,`
Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@`
`24`	`24`
`25`	`25`	`#include "mpc85xx.h"`
`26`	`26`
`27`		`-void __init p1010_rdb_pic_init(void)`
	`27`	`+static void __init p1010_rdb_pic_init(void)`
`28`	`28`	`{`
`29`	`29`	`struct mpic *mpic = mpic_alloc(NULL, 0, MPIC_BIG_ENDIAN \|`
`30`	`30`	`MPIC_SINGLE_DEST_CPU,`
Original file line number	Diff line number	Diff line change
`@@ -370,7 +370,7 @@ static void p1022ds_set_monitor_port(enum fsl_diu_monitor_port port)`
`370`	`370`	`*`
`371`	`371`	`* @pixclock: the wavelength, in picoseconds, of the clock`
`372`	`372`	`*/`
`373`		`-void p1022ds_set_pixel_clock(unsigned int pixclock)`
	`373`	`+static void p1022ds_set_pixel_clock(unsigned int pixclock)`
`374`	`374`	`{`
`375`	`375`	`struct device_node *guts_np = NULL;`
`376`	`376`	`struct ccsr_guts __iomem *guts;`
`@@ -418,7 +418,7 @@ void p1022ds_set_pixel_clock(unsigned int pixclock)`
`418`	`418`	`/**`
`419`	`419`	`* p1022ds_valid_monitor_port: set the monitor port for sysfs`
`420`	`420`	`*/`
`421`		`-enum fsl_diu_monitor_port`
	`421`	`+static enum fsl_diu_monitor_port`
`422`	`422`	`p1022ds_valid_monitor_port(enum fsl_diu_monitor_port port)`
`423`	`423`	`{`
`424`	`424`	`switch (port) {`
`@@ -432,7 +432,7 @@ p1022ds_valid_monitor_port(enum fsl_diu_monitor_port port)`
`432`	`432`
`433`	`433`	`#endif`
`434`	`434`
`435`		`-void __init p1022_ds_pic_init(void)`
	`435`	`+static void __init p1022_ds_pic_init(void)`
`436`	`436`	`{`
`437`	`437`	`struct mpic *mpic = mpic_alloc(NULL, 0, MPIC_BIG_ENDIAN \|`
`438`	`438`	`MPIC_SINGLE_DEST_CPU,`
Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@`
`40`	`40`	`*`
`41`	`41`	`* @pixclock: the wavelength, in picoseconds, of the clock`
`42`	`42`	`*/`
`43`		`-void p1022rdk_set_pixel_clock(unsigned int pixclock)`
	`43`	`+static void p1022rdk_set_pixel_clock(unsigned int pixclock)`
`44`	`44`	`{`
`45`	`45`	`struct device_node *guts_np = NULL;`
`46`	`46`	`struct ccsr_guts __iomem *guts;`
`@@ -88,15 +88,15 @@ void p1022rdk_set_pixel_clock(unsigned int pixclock)`
`88`	`88`	`/**`
`89`	`89`	`* p1022rdk_valid_monitor_port: set the monitor port for sysfs`
`90`	`90`	`*/`
`91`		`-enum fsl_diu_monitor_port`
	`91`	`+static enum fsl_diu_monitor_port`
`92`	`92`	`p1022rdk_valid_monitor_port(enum fsl_diu_monitor_port port)`
`93`	`93`	`{`
`94`	`94`	`return FSL_DIU_PORT_DVI;`
`95`	`95`	`}`
`96`	`96`
`97`	`97`	`#endif`
`98`	`98`
`99`		`-void __init p1022_rdk_pic_init(void)`
	`99`	`+static void __init p1022_rdk_pic_init(void)`
`100`	`100`	`{`
`101`	`101`	`struct mpic *mpic = mpic_alloc(NULL, 0, MPIC_BIG_ENDIAN \|`
`102`	`102`	`MPIC_SINGLE_DEST_CPU,`
Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@`
`37`	`37`	`#define MPC85xx_L2CTL_L2I 0x40000000 /* L2 flash invalidate */`
`38`	`38`	`#define MPC85xx_L2CTL_L2SIZ_MASK 0x30000000 /* L2 SRAM size (R/O) */`
`39`	`39`
`40`		`-void __init xes_mpc85xx_pic_init(void)`
	`40`	`+static void __init xes_mpc85xx_pic_init(void)`
`41`	`41`	`{`
`42`	`42`	`struct mpic *mpic = mpic_alloc(NULL, 0, MPIC_BIG_ENDIAN,`
`43`	`43`	`0, 256, " OpenPIC ");`