Skip to content

Commit 1b09c2b

Browse files
krzklinusw
authored andcommitted
pinctrl: samsung: constify iomem pointers
Constify few pointers to iomem, where the destination memory is not modified, for code safety and readability. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org> Link: https://lore.kernel.org/r/20231223191902.22857-1-krzysztof.kozlowski@linaro.org Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
1 parent 7d7cd22 commit 1b09c2b

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

drivers/pinctrl/samsung/pinctrl-exynos.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -693,7 +693,7 @@ static void exynos_pinctrl_suspend_bank(
693693
struct samsung_pin_bank *bank)
694694
{
695695
struct exynos_eint_gpio_save *save = bank->soc_priv;
696-
void __iomem *regs = bank->eint_base;
696+
const void __iomem *regs = bank->eint_base;
697697

698698
save->eint_con = readl(regs + EXYNOS_GPIO_ECON_OFFSET
699699
+ bank->eint_offset);
@@ -714,7 +714,7 @@ static void exynosauto_pinctrl_suspend_bank(struct samsung_pinctrl_drv_data *drv
714714
struct samsung_pin_bank *bank)
715715
{
716716
struct exynos_eint_gpio_save *save = bank->soc_priv;
717-
void __iomem *regs = bank->eint_base;
717+
const void __iomem *regs = bank->eint_base;
718718

719719
save->eint_con = readl(regs + bank->pctl_offset + bank->eint_con_offset);
720720
save->eint_mask = readl(regs + bank->pctl_offset + bank->eint_mask_offset);

drivers/pinctrl/samsung/pinctrl-samsung.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -565,7 +565,7 @@ static void samsung_gpio_set(struct gpio_chip *gc, unsigned offset, int value)
565565
/* gpiolib gpio_get callback function */
566566
static int samsung_gpio_get(struct gpio_chip *gc, unsigned offset)
567567
{
568-
void __iomem *reg;
568+
const void __iomem *reg;
569569
u32 data;
570570
struct samsung_pin_bank *bank = gpiochip_get_data(gc);
571571
const struct samsung_pin_bank_type *type = bank->type;
@@ -1204,7 +1204,7 @@ static int __maybe_unused samsung_pinctrl_suspend(struct device *dev)
12041204

12051205
for (i = 0; i < drvdata->nr_banks; i++) {
12061206
struct samsung_pin_bank *bank = &drvdata->pin_banks[i];
1207-
void __iomem *reg = bank->pctl_base + bank->pctl_offset;
1207+
const void __iomem *reg = bank->pctl_base + bank->pctl_offset;
12081208
const u8 *offs = bank->type->reg_offset;
12091209
const u8 *widths = bank->type->fld_width;
12101210
enum pincfg_type type;

0 commit comments

Comments
 (0)