Skip to content

Commit 1ac98d6

Browse files
krzkandersson
authored andcommitted
soc: qcom: pmic_glink: Drop redundant pg assignment before taking lock
Commit e9f826b ("soc: qcom: pmic_glink: simplify locking with guard()") was on top of a fix [1] which was moving the 'pg = __pmic_glink' assignment into the critical section. Unfortunately the actual fix was not applied and instead rebased version of the next patch got in. The resulting code is in general correct, but now there is a duplicated assignment 'pg = __pmic_glink'. [1] https://lore.kernel.org/all/20240822164815.230167-1-krzysztof.kozlowski@linaro.org/ Fixes: e9f826b ("soc: qcom: pmic_glink: simplify locking with guard()") Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Link: https://lore.kernel.org/r/20250111172326.101779-1-krzysztof.kozlowski@linaro.org Signed-off-by: Bjorn Andersson <andersson@kernel.org>
1 parent 2014c95 commit 1ac98d6

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/soc/qcom/pmic_glink.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,7 @@ static void pmic_glink_pdr_callback(int state, char *svc_path, void *priv)
233233

234234
static int pmic_glink_rpmsg_probe(struct rpmsg_device *rpdev)
235235
{
236-
struct pmic_glink *pg = __pmic_glink;
236+
struct pmic_glink *pg;
237237

238238
guard(mutex)(&__pmic_glink_lock);
239239
pg = __pmic_glink;

0 commit comments

Comments
 (0)