Skip to content

Commit 1aa77a7

Browse files
jhovoldlag-linaro
authored andcommitted
dt-bindings: mfd: hisilicon,hi6421-spmi-pmic: Clean up example
The SPMI PMIC sits on an SPMI bus which and has two address cells with no size. Clean up the example by adding a parent SPMI bus node with proper '#address-cells' and '#size-cells' properties, using a define for the second register value, dropping the unnecessary label and increasing the indentation to four spaces. Signed-off-by: Johan Hovold <johan+linaro@kernel.org> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Link: https://lore.kernel.org/r/20231206111754.7410-4-johan+linaro@kernel.org Signed-off-by: Lee Jones <lee@kernel.org>
1 parent d5c005f commit 1aa77a7

File tree

1 file changed

+70
-64
lines changed

1 file changed

+70
-64
lines changed

Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml

Lines changed: 70 additions & 64 deletions
Original file line numberDiff line numberDiff line change
@@ -59,69 +59,75 @@ additionalProperties: false
5959

6060
examples:
6161
- |
62-
63-
pmic: pmic@0 {
64-
compatible = "hisilicon,hi6421v600-spmi";
65-
reg = <0 0>;
66-
67-
#interrupt-cells = <2>;
68-
interrupt-controller;
69-
interrupt-parent = <&gpio28>;
70-
interrupts = <0 0>;
71-
72-
regulators {
73-
ldo3: ldo3 {
74-
regulator-name = "ldo3";
75-
regulator-min-microvolt = <1500000>;
76-
regulator-max-microvolt = <2000000>;
77-
regulator-boot-on;
78-
};
79-
80-
ldo4: ldo4 {
81-
regulator-name = "ldo4";
82-
regulator-min-microvolt = <1725000>;
83-
regulator-max-microvolt = <1900000>;
84-
regulator-boot-on;
85-
};
86-
87-
ldo9: ldo9 {
88-
regulator-name = "ldo9";
89-
regulator-min-microvolt = <1750000>;
90-
regulator-max-microvolt = <3300000>;
91-
regulator-boot-on;
92-
};
93-
94-
ldo15: ldo15 {
95-
regulator-name = "ldo15";
96-
regulator-min-microvolt = <1800000>;
97-
regulator-max-microvolt = <3000000>;
98-
regulator-always-on;
99-
};
100-
101-
ldo16: ldo16 {
102-
regulator-name = "ldo16";
103-
regulator-min-microvolt = <1800000>;
104-
regulator-max-microvolt = <3000000>;
105-
regulator-boot-on;
106-
};
107-
108-
ldo17: ldo17 {
109-
regulator-name = "ldo17";
110-
regulator-min-microvolt = <2500000>;
111-
regulator-max-microvolt = <3300000>;
112-
};
113-
114-
ldo33: ldo33 {
115-
regulator-name = "ldo33";
116-
regulator-min-microvolt = <2500000>;
117-
regulator-max-microvolt = <3300000>;
118-
regulator-boot-on;
119-
};
120-
121-
ldo34: ldo34 {
122-
regulator-name = "ldo34";
123-
regulator-min-microvolt = <2600000>;
124-
regulator-max-microvolt = <3300000>;
62+
#include <dt-bindings/spmi/spmi.h>
63+
64+
spmi {
65+
#address-cells = <2>;
66+
#size-cells = <0>;
67+
68+
pmic@0 {
69+
compatible = "hisilicon,hi6421v600-spmi";
70+
reg = <0 SPMI_USID>;
71+
72+
#interrupt-cells = <2>;
73+
interrupt-controller;
74+
interrupt-parent = <&gpio28>;
75+
interrupts = <0 0>;
76+
77+
regulators {
78+
ldo3 {
79+
regulator-name = "ldo3";
80+
regulator-min-microvolt = <1500000>;
81+
regulator-max-microvolt = <2000000>;
82+
regulator-boot-on;
83+
};
84+
85+
ldo4 {
86+
regulator-name = "ldo4";
87+
regulator-min-microvolt = <1725000>;
88+
regulator-max-microvolt = <1900000>;
89+
regulator-boot-on;
90+
};
91+
92+
ldo9 {
93+
regulator-name = "ldo9";
94+
regulator-min-microvolt = <1750000>;
95+
regulator-max-microvolt = <3300000>;
96+
regulator-boot-on;
97+
};
98+
99+
ldo15 {
100+
regulator-name = "ldo15";
101+
regulator-min-microvolt = <1800000>;
102+
regulator-max-microvolt = <3000000>;
103+
regulator-always-on;
104+
};
105+
106+
ldo16 {
107+
regulator-name = "ldo16";
108+
regulator-min-microvolt = <1800000>;
109+
regulator-max-microvolt = <3000000>;
110+
regulator-boot-on;
111+
};
112+
113+
ldo17 {
114+
regulator-name = "ldo17";
115+
regulator-min-microvolt = <2500000>;
116+
regulator-max-microvolt = <3300000>;
117+
};
118+
119+
ldo33 {
120+
regulator-name = "ldo33";
121+
regulator-min-microvolt = <2500000>;
122+
regulator-max-microvolt = <3300000>;
123+
regulator-boot-on;
124+
};
125+
126+
ldo34 {
127+
regulator-name = "ldo34";
128+
regulator-min-microvolt = <2600000>;
129+
regulator-max-microvolt = <3300000>;
130+
};
131+
};
125132
};
126-
};
127133
};

0 commit comments

Comments
 (0)