Skip to content

Commit 1a8b612

Browse files
committed
drm/msm: Take lru lock once per job_run
Rather than acquiring it and dropping it for each individual obj. Signed-off-by: Rob Clark <robdclark@chromium.org> Patchwork: https://patchwork.freedesktop.org/patch/551019/
1 parent a895037 commit 1a8b612

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

drivers/gpu/drm/msm/msm_gem.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -509,14 +509,11 @@ void msm_gem_unpin_locked(struct drm_gem_object *obj)
509509
*/
510510
void msm_gem_unpin_active(struct drm_gem_object *obj)
511511
{
512-
struct msm_drm_private *priv = obj->dev->dev_private;
513512
struct msm_gem_object *msm_obj = to_msm_bo(obj);
514513

515-
mutex_lock(&priv->lru.lock);
516514
msm_obj->pin_count--;
517515
GEM_WARN_ON(msm_obj->pin_count < 0);
518516
update_lru_active(obj);
519-
mutex_unlock(&priv->lru.lock);
520517
}
521518

522519
struct msm_gem_vma *msm_gem_get_vma_locked(struct drm_gem_object *obj,

drivers/gpu/drm/msm/msm_ringbuffer.c

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,13 @@ static struct dma_fence *msm_job_run(struct drm_sched_job *job)
1616
struct msm_gem_submit *submit = to_msm_submit(job);
1717
struct msm_fence_context *fctx = submit->ring->fctx;
1818
struct msm_gpu *gpu = submit->gpu;
19+
struct msm_drm_private *priv = gpu->dev->dev_private;
1920
int i;
2021

2122
msm_fence_init(submit->hw_fence, fctx);
2223

24+
mutex_lock(&priv->lru.lock);
25+
2326
for (i = 0; i < submit->nr_bos; i++) {
2427
struct drm_gem_object *obj = &submit->bos[i].obj->base;
2528

@@ -28,6 +31,8 @@ static struct dma_fence *msm_job_run(struct drm_sched_job *job)
2831
submit->bos[i].flags &= ~(BO_VMA_PINNED | BO_OBJ_PINNED);
2932
}
3033

34+
mutex_unlock(&priv->lru.lock);
35+
3136
/* TODO move submit path over to using a per-ring lock.. */
3237
mutex_lock(&gpu->lock);
3338

0 commit comments

Comments
 (0)