Skip to content

Commit 1956149

Browse files
committed
pinctrl: lynxpoint: Make use of pm_ptr()
Cleaning up the driver to use pm_ptr() and *_PM_OPS() macros that make it simpler and allows the compiler to remove those functions if built without CONFIG_PM and CONFIG_PM_SLEEP support. The lp_gpio_resume() is also assigned to .thaw and .restore members. This is not a problem as the function it enables input pins that had been disabled by firmware and repetion of that doesn't change the pin configuration, i.e. it is idempotent. Reviewed-by: Paul Cercueil <paul@crapouillou.net> Link: https://lore.kernel.org/r/20230717172821.62827-6-andriy.shevchenko@linux.intel.com Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
1 parent df660f6 commit 1956149

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

drivers/pinctrl/intel/pinctrl-lynxpoint.c

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -877,9 +877,8 @@ static int lp_gpio_resume(struct device *dev)
877877
}
878878

879879
static const struct dev_pm_ops lp_gpio_pm_ops = {
880-
.runtime_suspend = lp_gpio_runtime_suspend,
881-
.runtime_resume = lp_gpio_runtime_resume,
882-
.resume = lp_gpio_resume,
880+
SYSTEM_SLEEP_PM_OPS(NULL, lp_gpio_resume)
881+
RUNTIME_PM_OPS(lp_gpio_runtime_suspend, lp_gpio_runtime_resume, NULL)
883882
};
884883

885884
static const struct acpi_device_id lynxpoint_gpio_acpi_match[] = {
@@ -894,7 +893,7 @@ static struct platform_driver lp_gpio_driver = {
894893
.remove = lp_gpio_remove,
895894
.driver = {
896895
.name = "lp_gpio",
897-
.pm = &lp_gpio_pm_ops,
896+
.pm = pm_ptr(&lp_gpio_pm_ops),
898897
.acpi_match_table = lynxpoint_gpio_acpi_match,
899898
},
900899
};

0 commit comments

Comments
 (0)