Skip to content

Commit 17e94b2

Browse files
SEO HOYOUNGmartinkpetersen
authored andcommitted
scsi: ufs: core: Remove the ufshcd_release() in ufshcd_err_handling_prepare()
If ufshcd_err_handler() is called in a suspend/resume situation, ufs_release() can be called twice and active_reqs end up going negative. This is because ufshcd_err_handling_prepare() and ufshcd_err_handling_unprepare() both call ufshcd_release(). Remove superfluous call to ufshcd_release(). Signed-off-by: SEO HOYOUNG <hy50.seo@samsung.com> Link: https://lore.kernel.org/r/20240122083324.11797-1-hy50.seo@samsung.com Reviewed-by: Bart Van Assche <bvanassche@acm.org> Reviewed-by: Can Guo <quic_cang@quicinc.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
1 parent b513d30 commit 17e94b2

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

drivers/ufs/core/ufshcd.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6354,7 +6354,6 @@ static void ufshcd_err_handling_prepare(struct ufs_hba *hba)
63546354
ufshcd_hold(hba);
63556355
if (!ufshcd_is_clkgating_allowed(hba))
63566356
ufshcd_setup_clocks(hba, true);
6357-
ufshcd_release(hba);
63586357
pm_op = hba->is_sys_suspended ? UFS_SYSTEM_PM : UFS_RUNTIME_PM;
63596358
ufshcd_vops_resume(hba, pm_op);
63606359
} else {

0 commit comments

Comments
 (0)