Skip to content

Commit 17aaf9e

Browse files
Vijaya Krishna Nivarthibroonie
authored andcommitted
spi: spi-qcom-qspi: Ignore disabled interrupts' status in isr
During FIFO/DMA modes dynamic switching, only corresponding interrupts are enabled. However its possible that FIFO related interrupt status registers get set during DMA mode. For example WR_FIFO_EMPTY bit is set during DMA TX. Ignore such status bits so that they don't trip unwanted operations. Suggested-by: Douglas Anderson <dianders@chromium.org> Signed-off-by: Vijaya Krishna Nivarthi <quic_vnivarth@quicinc.com> Fixes: b5762d9 ("spi: spi-qcom-qspi: Add DMA mode support") Reviewed-by: Douglas Anderson <dianders@chromium.org> Tested-by: Douglas Anderson <dianders@chromium.org> Link: https://lore.kernel.org/r/1690285689-30233-2-git-send-email-quic_vnivarth@quicinc.com Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 6eaae19 commit 17aaf9e

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

drivers/spi/spi-qcom-qspi.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -603,6 +603,9 @@ static irqreturn_t qcom_qspi_irq(int irq, void *dev_id)
603603
int_status = readl(ctrl->base + MSTR_INT_STATUS);
604604
writel(int_status, ctrl->base + MSTR_INT_STATUS);
605605

606+
/* Ignore disabled interrupts */
607+
int_status &= readl(ctrl->base + MSTR_INT_EN);
608+
606609
/* PIO mode handling */
607610
if (ctrl->xfer.dir == QSPI_WRITE) {
608611
if (int_status & WR_FIFO_EMPTY)

0 commit comments

Comments
 (0)