flow_offload: return EOPNOTSUPP for the unsupported mpls action type

zhengbaowen · davem330 · commit 166b6a46b78b · 2021-12-14T12:33:19.000Z
We need to return EOPNOTSUPP for the unsupported mpls action type when setup the flow action. In the original implement, we will return 0 for the unsupported mpls action type, actually we do not setup it and the following actions to the flow action entry. Fixes: 9838b20 ("net: sched: take rtnl lock in tc_setup_flow_action()") Signed-off-by: Baowen Zheng <baowen.zheng@corigine.com> Signed-off-by: Simon Horman <simon.horman@corigine.com> Acked-by: Jamal Hadi Salim <jhs@mojatatu.com> Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c
@@ -3687,6 +3687,7 @@ int tc_setup_flow_action(struct flow_action *flow_action,
 				entry->mpls_mangle.ttl = tcf_mpls_ttl(act);
 				break;
 			default:
+				err = -EOPNOTSUPP;
 				goto err_out_locked;
 			}
 		} else if (is_tcf_skbedit_ptype(act)) {

Original file line number	Diff line number	Diff line change
`@@ -3687,6 +3687,7 @@ int tc_setup_flow_action(struct flow_action *flow_action,`
`3687`	`3687`	`entry->mpls_mangle.ttl = tcf_mpls_ttl(act);`
`3688`	`3688`	`break;`
`3689`	`3689`	`default:`
	`3690`	`+ err = -EOPNOTSUPP;`
`3690`	`3691`	`goto err_out_locked;`
`3691`	`3692`	`}`
`3692`	`3693`	`} else if (is_tcf_skbedit_ptype(act)) {`