Skip to content

Commit 1566bf4

Browse files
joelagnelpaulmckrcu
authored andcommitted
docs: memory-barriers: Add note on compiler transformation and address deps
The compiler has the ability to cause misordering by destroying address-dependency barriers if comparison operations are used. Add a note about this to memory-barriers.txt in the beginning of both the historical address-dependency sections and point to rcu-dereference.rst for more information. Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org> Cc: Alan Stern <stern@rowland.harvard.edu> Cc: Will Deacon <will@kernel.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Boqun Feng <boqun.feng@gmail.com> Cc: Nicholas Piggin <npiggin@gmail.com> Cc: David Howells <dhowells@redhat.com> Cc: Jade Alglave <j.alglave@ucl.ac.uk> Cc: Luc Maranget <luc.maranget@inria.fr> Cc: Akira Yokosawa <akiyks@gmail.com> Cc: Daniel Lustig <dlustig@nvidia.com> Cc: Joel Fernandes <joel@joelfernandes.org> Cc: Jonathan Corbet <corbet@lwn.net> Reviewed-by: Andrea Parri <parri.andrea@gmail.com> Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
1 parent 0bb80ec commit 1566bf4

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

Documentation/memory-barriers.txt

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -396,6 +396,10 @@ Memory barriers come in four basic varieties:
396396

397397

398398
(2) Address-dependency barriers (historical).
399+
[!] This section is marked as HISTORICAL: For more up-to-date
400+
information, including how compiler transformations related to pointer
401+
comparisons can sometimes cause problems, see
402+
Documentation/RCU/rcu_dereference.rst.
399403

400404
An address-dependency barrier is a weaker form of read barrier. In the
401405
case where two loads are performed such that the second depends on the
@@ -556,6 +560,9 @@ There are certain things that the Linux kernel memory barriers do not guarantee:
556560

557561
ADDRESS-DEPENDENCY BARRIERS (HISTORICAL)
558562
----------------------------------------
563+
[!] This section is marked as HISTORICAL: For more up-to-date information,
564+
including how compiler transformations related to pointer comparisons can
565+
sometimes cause problems, see Documentation/RCU/rcu_dereference.rst.
559566

560567
As of v4.15 of the Linux kernel, an smp_mb() was added to READ_ONCE() for
561568
DEC Alpha, which means that about the only people who need to pay attention

0 commit comments

Comments
 (0)