Skip to content

Commit 1560cb0

Browse files
committed
modpost: remove unneeded .symbol_white_list initializers
The ->symbol_white_list field is referenced in secref_whitelist(), only when 'fromsec' is data_sections. /* Check for pattern 2 */ if (match(tosec, init_exit_sections) && match(fromsec, data_sections) && match(fromsym, mismatch->symbol_white_list)) return 0; If .fromsec is not data sections, the .symbol_white_list member is not used by anyone. Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
1 parent 7452dd2 commit 1560cb0

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

scripts/mod/modpost.c

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -930,7 +930,6 @@ static const struct sectioncheck sectioncheck[] = {
930930
.fromsec = { TEXT_SECTIONS, NULL },
931931
.bad_tosec = { ALL_INIT_SECTIONS, NULL },
932932
.mismatch = TEXT_TO_ANY_INIT,
933-
.symbol_white_list = { DEFAULT_SYMBOL_WHITE_LIST, NULL },
934933
},
935934
{
936935
.fromsec = { DATA_SECTIONS, NULL },
@@ -951,7 +950,6 @@ static const struct sectioncheck sectioncheck[] = {
951950
.fromsec = { TEXT_SECTIONS, NULL },
952951
.bad_tosec = { ALL_EXIT_SECTIONS, NULL },
953952
.mismatch = TEXT_TO_ANY_EXIT,
954-
.symbol_white_list = { DEFAULT_SYMBOL_WHITE_LIST, NULL },
955953
},
956954
{
957955
.fromsec = { DATA_SECTIONS, NULL },
@@ -964,41 +962,35 @@ static const struct sectioncheck sectioncheck[] = {
964962
.fromsec = { ALL_XXXINIT_SECTIONS, NULL },
965963
.bad_tosec = { INIT_SECTIONS, NULL },
966964
.mismatch = XXXINIT_TO_SOME_INIT,
967-
.symbol_white_list = { DEFAULT_SYMBOL_WHITE_LIST, NULL },
968965
},
969966
/* Do not reference exit code/data from memexit code/data */
970967
{
971968
.fromsec = { ALL_XXXEXIT_SECTIONS, NULL },
972969
.bad_tosec = { EXIT_SECTIONS, NULL },
973970
.mismatch = XXXEXIT_TO_SOME_EXIT,
974-
.symbol_white_list = { DEFAULT_SYMBOL_WHITE_LIST, NULL },
975971
},
976972
/* Do not use exit code/data from init code */
977973
{
978974
.fromsec = { ALL_INIT_SECTIONS, NULL },
979975
.bad_tosec = { ALL_EXIT_SECTIONS, NULL },
980976
.mismatch = ANY_INIT_TO_ANY_EXIT,
981-
.symbol_white_list = { DEFAULT_SYMBOL_WHITE_LIST, NULL },
982977
},
983978
/* Do not use init code/data from exit code */
984979
{
985980
.fromsec = { ALL_EXIT_SECTIONS, NULL },
986981
.bad_tosec = { ALL_INIT_SECTIONS, NULL },
987982
.mismatch = ANY_EXIT_TO_ANY_INIT,
988-
.symbol_white_list = { DEFAULT_SYMBOL_WHITE_LIST, NULL },
989983
},
990984
{
991985
.fromsec = { ALL_PCI_INIT_SECTIONS, NULL },
992986
.bad_tosec = { INIT_SECTIONS, NULL },
993987
.mismatch = ANY_INIT_TO_ANY_EXIT,
994-
.symbol_white_list = { NULL },
995988
},
996989
/* Do not export init/exit functions or data */
997990
{
998991
.fromsec = { "___ksymtab*", NULL },
999992
.bad_tosec = { INIT_SECTIONS, EXIT_SECTIONS, NULL },
1000993
.mismatch = EXPORT_TO_INIT_EXIT,
1001-
.symbol_white_list = { DEFAULT_SYMBOL_WHITE_LIST, NULL },
1002994
},
1003995
{
1004996
.fromsec = { "__ex_table", NULL },

0 commit comments

Comments
 (0)