Skip to content

Commit 1435e89

Browse files
ISCAS-Vulabalexdeucher
authored andcommitted
drm/amdgpu: handle amdgpu_cgs_create_device() errors in amd_powerplay_create()
Add error handling to propagate amdgpu_cgs_create_device() failures to the caller. When amdgpu_cgs_create_device() fails, release hwmgr and return -ENOMEM to prevent null pointer dereference. [v1]->[v2]: Change error code from -EINVAL to -ENOMEM. Free hwmgr. Signed-off-by: Wentao Liang <vulab@iscas.ac.cn> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
1 parent bd4b125 commit 1435e89

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,11 @@ static int amd_powerplay_create(struct amdgpu_device *adev)
5151
hwmgr->adev = adev;
5252
hwmgr->not_vf = !amdgpu_sriov_vf(adev);
5353
hwmgr->device = amdgpu_cgs_create_device(adev);
54+
if (!hwmgr->device) {
55+
kfree(hwmgr);
56+
return -ENOMEM;
57+
}
58+
5459
mutex_init(&hwmgr->msg_lock);
5560
hwmgr->chip_family = adev->family;
5661
hwmgr->chip_id = adev->asic_type;

0 commit comments

Comments
 (0)