Skip to content

Commit 1400c87

Browse files
author
Ingo Molnar
committed
zstd: Increase DYNAMIC_BMI2 GCC version cutoff from 4.8 to 11.0 to work around compiler segfault
Due to pending percpu improvements in -next, GCC9 and GCC10 are crashing during the build with: lib/zstd/compress/huf_compress.c:1033:1: internal compiler error: Segmentation fault 1033 | { | ^ Please submit a full bug report, with preprocessed source if appropriate. See <file:///usr/share/doc/gcc-9/README.Bugs> for instructions. The DYNAMIC_BMI2 feature is a known-challenging feature of the ZSTD library, with an existing GCC quirk turning it off for GCC versions below 4.8. Increase the DYNAMIC_BMI2 version cutoff to GCC 11.0 - GCC 10.5 is the last version known to crash. Reported-by: Michael Kelley <mhklinux@outlook.com> Debugged-by: Ard Biesheuvel <ardb@kernel.org> Signed-off-by: Ingo Molnar <mingo@kernel.org> Cc: https://lore.kernel.org/r/SN6PR02MB415723FBCD79365E8D72CA5FD4D82@SN6PR02MB4157.namprd02.prod.outlook.com Cc: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 3e57612 commit 1400c87

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

lib/zstd/common/portability_macros.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@
5555
#ifndef DYNAMIC_BMI2
5656
#if ((defined(__clang__) && __has_attribute(__target__)) \
5757
|| (defined(__GNUC__) \
58-
&& (__GNUC__ >= 5 || (__GNUC__ == 4 && __GNUC_MINOR__ >= 8)))) \
58+
&& (__GNUC__ >= 11))) \
5959
&& (defined(__x86_64__) || defined(_M_X64)) \
6060
&& !defined(__BMI2__)
6161
# define DYNAMIC_BMI2 1

0 commit comments

Comments
 (0)