Skip to content

Commit 12d823b

Browse files
committed
eventfs: Remove fsnotify*() functions from lookup()
The dentries and inodes are created when referenced in the lookup code. There's no reason to call fsnotify_*() functions when they are created by a reference. It doesn't make any sense. Link: https://lore.kernel.org/linux-trace-kernel/20240201002719.GS2087318@ZenIV/ Link: https://lore.kernel.org/linux-trace-kernel/20240201161617.166973329@goodmis.org Cc: stable@vger.kernel.org Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Masami Hiramatsu <mhiramat@kernel.org> Cc: Mark Rutland <mark.rutland@arm.com> Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Cc: Christian Brauner <brauner@kernel.org> Cc: Al Viro <viro@ZenIV.linux.org.uk> Cc: Ajay Kaher <ajay.kaher@broadcom.com> Fixes: a376007 ("eventfs: Implement functions to create files and dirs when accessed"); Suggested-by: Al Viro <viro@zeniv.linux.org.uk> Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
1 parent 264424d commit 12d823b

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

fs/tracefs/event_inode.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -366,7 +366,6 @@ static struct dentry *lookup_file(struct eventfs_inode *parent_ei,
366366
dentry->d_fsdata = get_ei(parent_ei);
367367

368368
d_add(dentry, inode);
369-
fsnotify_create(dentry->d_parent->d_inode, dentry);
370369
return NULL;
371370
};
372371

@@ -408,7 +407,6 @@ static struct dentry *lookup_dir_entry(struct dentry *dentry,
408407
inc_nlink(inode);
409408
d_add(dentry, inode);
410409
inc_nlink(dentry->d_parent->d_inode);
411-
fsnotify_mkdir(dentry->d_parent->d_inode, dentry);
412410
return NULL;
413411
}
414412

0 commit comments

Comments
 (0)