Skip to content

Commit 1180968

Browse files
jnikulajlahtine-intel
authored andcommitted
drm/i915: don't make assumptions about intel_wakeref_t type
intel_wakeref_t is supposed to be a mostly opaque cookie to its users. It should only be checked for being non-zero and set to zero. Debug logging its actual value is meaningless. Switch to just debug logging whether the async_put_wakeref is non-zero. The issue dates back to much earlier than commit b49e894 ("drm/i915: Replace custom intel runtime_pm tracker with ref_tracker library"), but this is the one that brought about a build failure due to the printf format. Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> Closes: https://lore.kernel.org/r/20240102111222.2db11208@canb.auug.org.au Fixes: b49e894 ("drm/i915: Replace custom intel runtime_pm tracker with ref_tracker library") Cc: Andrzej Hajda <andrzej.hajda@intel.com> Cc: Imre Deak <imre.deak@intel.com> Signed-off-by: Jani Nikula <jani.nikula@intel.com> Reviewed-by: Imre Deak <imre.deak@intel.com> Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20240104164600.783371-1-jani.nikula@intel.com (cherry picked from commit de06b42) Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
1 parent ae8986e commit 1180968

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/gpu/drm/i915/display/intel_display_power.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -405,8 +405,8 @@ print_async_put_domains_state(struct i915_power_domains *power_domains)
405405
struct drm_i915_private,
406406
display.power.domains);
407407

408-
drm_dbg(&i915->drm, "async_put_wakeref %lu\n",
409-
power_domains->async_put_wakeref);
408+
drm_dbg(&i915->drm, "async_put_wakeref: %s\n",
409+
str_yes_no(power_domains->async_put_wakeref));
410410

411411
print_power_domains(power_domains, "async_put_domains[0]",
412412
&power_domains->async_put_domains[0]);

0 commit comments

Comments
 (0)