Skip to content

Commit 1108d67

Browse files
committed
PCI: dwc: Simplify config resource lookup
If platform_get_resource_byname("config") fails, return error immediately and unindent the normal path. No functional change intended. Link: https://lore.kernel.org/r/20250117235119.712043-1-helgaas@kernel.org Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Reviewed-by: Frank Li <Frank.Li@nxp.com> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
1 parent 4dbf015 commit 1108d67

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

drivers/pci/controller/dwc/pcie-designware-host.c

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -436,18 +436,18 @@ int dw_pcie_host_init(struct dw_pcie_rp *pp)
436436
return ret;
437437

438438
res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "config");
439-
if (res) {
440-
pp->cfg0_size = resource_size(res);
441-
pp->cfg0_base = res->start;
442-
443-
pp->va_cfg0_base = devm_pci_remap_cfg_resource(dev, res);
444-
if (IS_ERR(pp->va_cfg0_base))
445-
return PTR_ERR(pp->va_cfg0_base);
446-
} else {
447-
dev_err(dev, "Missing *config* reg space\n");
439+
if (!res) {
440+
dev_err(dev, "Missing \"config\" reg space\n");
448441
return -ENODEV;
449442
}
450443

444+
pp->cfg0_size = resource_size(res);
445+
pp->cfg0_base = res->start;
446+
447+
pp->va_cfg0_base = devm_pci_remap_cfg_resource(dev, res);
448+
if (IS_ERR(pp->va_cfg0_base))
449+
return PTR_ERR(pp->va_cfg0_base);
450+
451451
bridge = devm_pci_alloc_host_bridge(dev, 0);
452452
if (!bridge)
453453
return -ENOMEM;

0 commit comments

Comments
 (0)