Skip to content

Commit 0f1cbf9

Browse files
jgunthorpeAlexander Gordeev
authored andcommitted
s390/iommu: get rid of S390_CCW_IOMMU and S390_AP_IOMMU
These don't do anything anymore, the only user of the symbol was VFIO_CCW/AP which already "depends on VFIO" and VFIO itself selects IOMMU_API. When this was added VFIO was wrongly doing "depends on IOMMU_API" which required some contortions like this to ensure IOMMU_API was turned on. Reviewed-by: Eric Farman <farman@linux.ibm.com> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com> Link: https://lore.kernel.org/r/0-v2-eb322ce2e547+188f-rm_iommu_ccw_jgg@nvidia.com Signed-off-by: Alexander Gordeev <agordeev@linux.ibm.com>
1 parent e534167 commit 0f1cbf9

File tree

5 files changed

+1
-23
lines changed

5 files changed

+1
-23
lines changed

Documentation/s390/vfio-ap.rst

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -551,7 +551,6 @@ These are the steps:
551551
* IOMMU_SUPPORT
552552
* S390
553553
* ZCRYPT
554-
* S390_AP_IOMMU
555554
* VFIO
556555
* KVM
557556

arch/s390/Kconfig

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -708,7 +708,6 @@ config EADM_SCH
708708
config VFIO_CCW
709709
def_tristate n
710710
prompt "Support for VFIO-CCW subchannels"
711-
depends on S390_CCW_IOMMU
712711
depends on VFIO
713712
select VFIO_MDEV
714713
help
@@ -720,7 +719,7 @@ config VFIO_CCW
720719
config VFIO_AP
721720
def_tristate n
722721
prompt "VFIO support for AP devices"
723-
depends on S390_AP_IOMMU && KVM
722+
depends on KVM
724723
depends on VFIO
725724
depends on ZCRYPT
726725
select VFIO_MDEV

arch/s390/configs/debug_defconfig

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -591,8 +591,6 @@ CONFIG_VIRTIO_BALLOON=m
591591
CONFIG_VIRTIO_INPUT=y
592592
CONFIG_VHOST_NET=m
593593
CONFIG_VHOST_VSOCK=m
594-
CONFIG_S390_CCW_IOMMU=y
595-
CONFIG_S390_AP_IOMMU=y
596594
CONFIG_EXT4_FS=y
597595
CONFIG_EXT4_FS_POSIX_ACL=y
598596
CONFIG_EXT4_FS_SECURITY=y

arch/s390/configs/defconfig

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -580,8 +580,6 @@ CONFIG_VIRTIO_BALLOON=m
580580
CONFIG_VIRTIO_INPUT=y
581581
CONFIG_VHOST_NET=m
582582
CONFIG_VHOST_VSOCK=m
583-
CONFIG_S390_CCW_IOMMU=y
584-
CONFIG_S390_AP_IOMMU=y
585583
CONFIG_EXT4_FS=y
586584
CONFIG_EXT4_FS_POSIX_ACL=y
587585
CONFIG_EXT4_FS_SECURITY=y

drivers/iommu/Kconfig

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -417,22 +417,6 @@ config S390_IOMMU
417417
help
418418
Support for the IOMMU API for s390 PCI devices.
419419

420-
config S390_CCW_IOMMU
421-
bool "S390 CCW IOMMU Support"
422-
depends on S390 && CCW || COMPILE_TEST
423-
select IOMMU_API
424-
help
425-
Enables bits of IOMMU API required by VFIO. The iommu_ops
426-
is not implemented as it is not necessary for VFIO.
427-
428-
config S390_AP_IOMMU
429-
bool "S390 AP IOMMU Support"
430-
depends on S390 && ZCRYPT || COMPILE_TEST
431-
select IOMMU_API
432-
help
433-
Enables bits of IOMMU API required by VFIO. The iommu_ops
434-
is not implemented as it is not necessary for VFIO.
435-
436420
config MTK_IOMMU
437421
tristate "MediaTek IOMMU Support"
438422
depends on ARCH_MEDIATEK || COMPILE_TEST

0 commit comments

Comments
 (0)