Skip to content

Commit 0dacc3d

Browse files
Maxim Levitskybonzini
authored andcommitted
KVM: x86: SVM: fix avic spec based definitions again
Due to wrong rebase, commit 4a204f7 ("KVM: SVM: Allow AVIC support on system w/ physical APIC ID > 255") moved avic spec #defines back to avic.c. Move them back, and while at it extend AVIC_DOORBELL_PHYSICAL_ID_MASK to 12 bits as well (it will be used in nested avic) Signed-off-by: Maxim Levitsky <mlevitsk@redhat.com> Message-Id: <20220322172449.235575-5-mlevitsk@redhat.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
1 parent fe5f691 commit 0dacc3d

File tree

2 files changed

+5
-14
lines changed

2 files changed

+5
-14
lines changed

arch/x86/include/asm/svm.h

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -222,17 +222,19 @@ struct __attribute__ ((__packed__)) vmcb_control_area {
222222

223223

224224
/* AVIC */
225-
#define AVIC_LOGICAL_ID_ENTRY_GUEST_PHYSICAL_ID_MASK (0xFF)
225+
#define AVIC_LOGICAL_ID_ENTRY_GUEST_PHYSICAL_ID_MASK (0xFFULL)
226226
#define AVIC_LOGICAL_ID_ENTRY_VALID_BIT 31
227227
#define AVIC_LOGICAL_ID_ENTRY_VALID_MASK (1 << 31)
228228

229229
#define AVIC_PHYSICAL_ID_ENTRY_HOST_PHYSICAL_ID_MASK GENMASK_ULL(11, 0)
230230
#define AVIC_PHYSICAL_ID_ENTRY_BACKING_PAGE_MASK (0xFFFFFFFFFFULL << 12)
231231
#define AVIC_PHYSICAL_ID_ENTRY_IS_RUNNING_MASK (1ULL << 62)
232232
#define AVIC_PHYSICAL_ID_ENTRY_VALID_MASK (1ULL << 63)
233-
#define AVIC_PHYSICAL_ID_TABLE_SIZE_MASK (0xFF)
233+
#define AVIC_PHYSICAL_ID_TABLE_SIZE_MASK (0xFFULL)
234234

235-
#define AVIC_DOORBELL_PHYSICAL_ID_MASK (0xFF)
235+
#define AVIC_DOORBELL_PHYSICAL_ID_MASK GENMASK_ULL(11, 0)
236+
237+
#define VMCB_AVIC_APIC_BAR_MASK 0xFFFFFFFFFF000ULL
236238

237239
#define AVIC_UNACCEL_ACCESS_WRITE_MASK 1
238240
#define AVIC_UNACCEL_ACCESS_OFFSET_MASK 0xFF0

arch/x86/kvm/svm/svm.h

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -571,17 +571,6 @@ extern struct kvm_x86_nested_ops svm_nested_ops;
571571

572572
/* avic.c */
573573

574-
#define AVIC_LOGICAL_ID_ENTRY_GUEST_PHYSICAL_ID_MASK (0xFF)
575-
#define AVIC_LOGICAL_ID_ENTRY_VALID_BIT 31
576-
#define AVIC_LOGICAL_ID_ENTRY_VALID_MASK (1 << 31)
577-
578-
#define AVIC_PHYSICAL_ID_ENTRY_HOST_PHYSICAL_ID_MASK GENMASK_ULL(11, 0)
579-
#define AVIC_PHYSICAL_ID_ENTRY_BACKING_PAGE_MASK (0xFFFFFFFFFFULL << 12)
580-
#define AVIC_PHYSICAL_ID_ENTRY_IS_RUNNING_MASK (1ULL << 62)
581-
#define AVIC_PHYSICAL_ID_ENTRY_VALID_MASK (1ULL << 63)
582-
583-
#define VMCB_AVIC_APIC_BAR_MASK 0xFFFFFFFFFF000ULL
584-
585574
int avic_ga_log_notifier(u32 ga_tag);
586575
void avic_vm_destroy(struct kvm *kvm);
587576
int avic_vm_init(struct kvm *kvm);

0 commit comments

Comments
 (0)