Skip to content

Commit 0d086cc

Browse files
Uwe Kleine-Königbebarino
authored andcommitted
clk: uniphier: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/20230312161512.2715500-29-u.kleine-koenig@pengutronix.de Signed-off-by: Stephen Boyd <sboyd@kernel.org>
1 parent c8bb21b commit 0d086cc

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

drivers/clk/uniphier/clk-uniphier-core.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -91,11 +91,9 @@ static int uniphier_clk_probe(struct platform_device *pdev)
9191
hw_data);
9292
}
9393

94-
static int uniphier_clk_remove(struct platform_device *pdev)
94+
static void uniphier_clk_remove(struct platform_device *pdev)
9595
{
9696
of_clk_del_provider(pdev->dev.of_node);
97-
98-
return 0;
9997
}
10098

10199
static const struct of_device_id uniphier_clk_match[] = {
@@ -220,7 +218,7 @@ static const struct of_device_id uniphier_clk_match[] = {
220218

221219
static struct platform_driver uniphier_clk_driver = {
222220
.probe = uniphier_clk_probe,
223-
.remove = uniphier_clk_remove,
221+
.remove_new = uniphier_clk_remove,
224222
.driver = {
225223
.name = "uniphier-clk",
226224
.of_match_table = uniphier_clk_match,

0 commit comments

Comments
 (0)