Skip to content

Commit 0c9d2d2

Browse files
LorenzoBianconikwilczynski
authored andcommitted
PCI: mediatek-gen3: Add comment about initialization order in mtk_pcie_en7581_power_up()
Add a comment in mtk_pcie_en7581_power_up() to clarify, unlike the other MediaTek Gen3 controllers, the Airoha EN7581 requires PHY initialization and power-on before PHY reset deassert. Link: https://lore.kernel.org/r/20250108-pcie-en7581-fixes-v6-3-21ac939a3b9b@kernel.org Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org> Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
1 parent e4c7dfd commit 0c9d2d2

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

drivers/pci/controller/pcie-mediatek-gen3.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -925,6 +925,10 @@ static int mtk_pcie_en7581_power_up(struct mtk_gen3_pcie *pcie)
925925
/* Wait for the time needed to complete the reset lines assert. */
926926
mdelay(PCIE_EN7581_RESET_TIME_MS);
927927

928+
/*
929+
* Unlike the other MediaTek Gen3 controllers, the Airoha EN7581
930+
* requires PHY initialization and power-on before PHY reset deassert.
931+
*/
928932
err = phy_init(pcie->phy);
929933
if (err) {
930934
dev_err(dev, "failed to initialize PHY\n");

0 commit comments

Comments
 (0)