Skip to content

Commit 0c15469

Browse files
mapicccyvinodkoul
authored andcommitted
dmaengine: idxd: Fix incorrect descriptions for GRPCFG register
Fix incorrect descriptions for the GRPCFG register which has three sub-registers (GRPWQCFG, GRPENGCFG and GRPFLGCFG). No functional changes Signed-off-by: Guanjun <guanjun@linux.alibaba.com> Reviewed-by: Dave Jiang <dave.jiang@intel.com> Reviewed-by: Fenghua Yu <fenghua.yu@intel.com> Acked-by: Lijun Pan <lijun.pan@intel.com> Link: https://lore.kernel.org/r/20231211053704.2725417-3-guanjun@linux.alibaba.com Signed-off-by: Vinod Koul <vkoul@kernel.org>
1 parent 778dfac commit 0c15469

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

drivers/dma/idxd/registers.h

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -440,12 +440,14 @@ union wqcfg {
440440
/*
441441
* This macro calculates the offset into the GRPCFG register
442442
* idxd - struct idxd *
443-
* n - wq id
444-
* ofs - the index of the 32b dword for the config register
443+
* n - group id
444+
* ofs - the index of the 64b qword for the config register
445445
*
446-
* The WQCFG register block is divided into groups per each wq. The n index
447-
* allows us to move to the register group that's for that particular wq.
448-
* Each register is 32bits. The ofs gives us the number of register to access.
446+
* The GRPCFG register block is divided into three sub-registers, which
447+
* are GRPWQCFG, GRPENGCFG and GRPFLGCFG. The n index allows us to move
448+
* to the register block that contains the three sub-registers.
449+
* Each register block is 64bits. And the ofs gives us the offset
450+
* within the GRPWQCFG register to access.
449451
*/
450452
#define GRPWQCFG_OFFSET(idxd_dev, n, ofs) ((idxd_dev)->grpcfg_offset +\
451453
(n) * GRPCFG_SIZE + sizeof(u64) * (ofs))

0 commit comments

Comments
 (0)