Skip to content

Commit 0b7a481

Browse files
calebsanderaxboe
authored andcommitted
ublk: don't suggest CONFIG_BLK_DEV_UBLK=Y
The CONFIG_BLK_DEV_UBLK help text suggests setting the config option to Y so task_work_add() can be used to dispatch I/O, improving performance. However, this mechanism was removed in commit 29dc5d0 ("ublk: kill queuing request by task_work_add"). So remove this paragraph from the config help text. Signed-off-by: Caleb Sander Mateos <csander@purestorage.com> Reviewed-by: Uday Shankar <ushankar@purestorage.com> Link: https://lore.kernel.org/r/20250416004111.3242817-1-csander@purestorage.com Signed-off-by: Jens Axboe <axboe@kernel.dk>
1 parent f2fed44 commit 0b7a481

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

drivers/block/Kconfig

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -388,12 +388,6 @@ config BLK_DEV_UBLK
388388
definition isn't finalized yet, and might change according to future
389389
requirement, so mark is as experimental now.
390390

391-
Say Y if you want to get better performance because task_work_add()
392-
can be used in IO path for replacing io_uring cmd, which will become
393-
shared between IO tasks and ubq daemon, meantime task_work_add() can
394-
can handle batch more effectively, but task_work_add() isn't exported
395-
for module, so ublk has to be built to kernel.
396-
397391
config BLKDEV_UBLK_LEGACY_OPCODES
398392
bool "Support legacy command opcode"
399393
depends on BLK_DEV_UBLK

0 commit comments

Comments
 (0)