Skip to content

Commit 08713cb

Browse files
author
Florian Westphal
committed
netfilter: nf_tables: fix kdoc warnings after gc rework
Jakub Kicinski says: We've got some new kdoc warnings here: net/netfilter/nft_set_pipapo.c:1557: warning: Function parameter or member '_set' not described in 'pipapo_gc' net/netfilter/nft_set_pipapo.c:1557: warning: Excess function parameter 'set' description in 'pipapo_gc' include/net/netfilter/nf_tables.h:577: warning: Function parameter or member 'dead' not described in 'nft_set' Fixes: 5f68718 ("netfilter: nf_tables: GC transaction API to avoid race with control plane") Fixes: f6c383b ("netfilter: nf_tables: adapt set backend to use GC transaction API") Reported-by: Jakub Kicinski <kuba@kernel.org> Closes: https://lore.kernel.org/netdev/20230810104638.746e46f1@kernel.org/ Signed-off-by: Florian Westphal <fw@strlen.de>
1 parent b9f052d commit 08713cb

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

include/net/netfilter/nf_tables.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -534,6 +534,7 @@ struct nft_set_elem_expr {
534534
* @expr: stateful expression
535535
* @ops: set ops
536536
* @flags: set flags
537+
* @dead: set will be freed, never cleared
537538
* @genmask: generation mask
538539
* @klen: key length
539540
* @dlen: data length

net/netfilter/nft_set_pipapo.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1549,7 +1549,7 @@ static void nft_pipapo_gc_deactivate(struct net *net, struct nft_set *set,
15491549

15501550
/**
15511551
* pipapo_gc() - Drop expired entries from set, destroy start and end elements
1552-
* @set: nftables API set representation
1552+
* @_set: nftables API set representation
15531553
* @m: Matching data
15541554
*/
15551555
static void pipapo_gc(const struct nft_set *_set, struct nft_pipapo_match *m)

0 commit comments

Comments
 (0)