Skip to content

Commit 06efafd

Browse files
gobenjikuba-moo
authored andcommitted
selftests: net: List helper scripts in TEST_FILES Makefile variable
Some scripts are not tests themselves; they contain utility functions used by other tests. According to Documentation/dev-tools/kselftest.rst, such files should be listed in TEST_FILES. Move those utility scripts to TEST_FILES. Fixes: 1751eb4 ("selftests: net: use TEST_PROGS_EXTENDED") Fixes: 25ae948 ("selftests/net: add lib.sh") Fixes: b99ac18 ("kselftests/net: add missed setup_loopback.sh/setup_veth.sh to Makefile") Fixes: f5173fe ("selftests: net: included needed helper in the install targets") Suggested-by: Petr Machata <petrm@nvidia.com> Signed-off-by: Benjamin Poirier <bpoirier@nvidia.com> Link: https://lore.kernel.org/r/20240131140848.360618-5-bpoirier@nvidia.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 9d851dd commit 06efafd

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

tools/testing/selftests/net/Makefile

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,9 +53,7 @@ TEST_PROGS += bind_bhash.sh
5353
TEST_PROGS += ip_local_port_range.sh
5454
TEST_PROGS += rps_default_mask.sh
5555
TEST_PROGS += big_tcp.sh
56-
TEST_PROGS_EXTENDED := in_netns.sh setup_loopback.sh setup_veth.sh
57-
TEST_PROGS_EXTENDED += toeplitz_client.sh toeplitz.sh lib.sh
58-
TEST_PROGS_EXTENDED += net_helper.sh
56+
TEST_PROGS_EXTENDED := toeplitz_client.sh toeplitz.sh
5957
TEST_GEN_FILES = socket nettest
6058
TEST_GEN_FILES += psock_fanout psock_tpacket msg_zerocopy reuseport_addr_any
6159
TEST_GEN_FILES += tcp_mmap tcp_inq psock_snd txring_overwrite
@@ -97,6 +95,7 @@ TEST_PROGS += fq_band_pktlimit.sh
9795
TEST_PROGS += vlan_hw_filter.sh
9896

9997
TEST_FILES := settings
98+
TEST_FILES += in_netns.sh lib.sh net_helper.sh setup_loopback.sh setup_veth.sh
10099

101100
include ../lib.mk
102101

0 commit comments

Comments
 (0)