Skip to content

Commit 06eaa53

Browse files
Bartosz Golaszewskipateldipen1984-nv
authored andcommitted
hte: tegra194: improve the GPIO-related comment
Using any of the GPIO interfaces using the global numberspace is deprecated. Make it clear in the comment. Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> Acked-by: Linus Walleij <linus.walleij@linaro.org> Reviewed-by: Dipen Patel <dipenp@nvidia.com> Signed-off-by: Dipen Patel <dipenp@nvidia.com>
1 parent 63137be commit 06eaa53

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

drivers/hte/hte-tegra194.c

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -407,12 +407,15 @@ static int tegra_hte_line_xlate(struct hte_chip *gc,
407407
return -EINVAL;
408408

409409
/*
410+
* GPIO consumers can access GPIOs in two ways:
410411
*
411-
* There are two paths GPIO consumers can take as follows:
412-
* 1) The consumer (gpiolib-cdev for example) which uses GPIO global
413-
* number which gets assigned run time.
414-
* 2) The consumer passing GPIO from the DT which is assigned
415-
* statically for example by using TEGRA194_AON_GPIO gpio DT binding.
412+
* 1) Using the global GPIO numberspace.
413+
*
414+
* This is the old, now DEPRECATED method and should not be used in
415+
* new code. TODO: Check if tegra is even concerned by this.
416+
*
417+
* 2) Using GPIO descriptors that can be assigned to consumer devices
418+
* using device-tree, ACPI or lookup tables.
416419
*
417420
* The code below addresses both the consumer use cases and maps into
418421
* HTE/GTE namespace.

0 commit comments

Comments
 (0)