@@ -45,11 +45,11 @@ def __init__(self, size=None, nr_accesses=None, age=None):
45
45
self .nr_accesses = nr_accesses
46
46
self .age = age
47
47
48
- if self .size == None :
48
+ if self .size is None :
49
49
self .size = [0 , 2 ** 64 - 1 ]
50
- if self .nr_accesses == None :
50
+ if self .nr_accesses is None :
51
51
self .nr_accesses = [0 , 2 ** 64 - 1 ]
52
- if self .age == None :
52
+ if self .age is None :
53
53
self .age = [0 , 2 ** 64 - 1 ]
54
54
55
55
def sysfs_dir (self ):
@@ -58,27 +58,27 @@ def sysfs_dir(self):
58
58
def stage (self ):
59
59
err = write_file (
60
60
os .path .join (self .sysfs_dir (), 'sz' , 'min' ), self .size [0 ])
61
- if err != None :
61
+ if err is not None :
62
62
return err
63
63
err = write_file (
64
64
os .path .join (self .sysfs_dir (), 'sz' , 'max' ), self .size [1 ])
65
- if err != None :
65
+ if err is not None :
66
66
return err
67
67
err = write_file (os .path .join (self .sysfs_dir (), 'nr_accesses' , 'min' ),
68
68
self .nr_accesses [0 ])
69
- if err != None :
69
+ if err is not None :
70
70
return err
71
71
err = write_file (os .path .join (self .sysfs_dir (), 'nr_accesses' , 'max' ),
72
72
self .nr_accesses [1 ])
73
- if err != None :
73
+ if err is not None :
74
74
return err
75
75
err = write_file (
76
76
os .path .join (self .sysfs_dir (), 'age' , 'min' ), self .age [0 ])
77
- if err != None :
77
+ if err is not None :
78
78
return err
79
79
err = write_file (
80
80
os .path .join (self .sysfs_dir (), 'age' , 'max' ), self .age [1 ])
81
- if err != None :
81
+ if err is not None :
82
82
return err
83
83
84
84
qgoal_metric_user_input = 'user_input'
@@ -137,14 +137,14 @@ def sysfs_dir(self):
137
137
138
138
def stage (self ):
139
139
err = write_file (os .path .join (self .sysfs_dir (), 'bytes' ), self .sz )
140
- if err != None :
140
+ if err is not None :
141
141
return err
142
142
err = write_file (os .path .join (self .sysfs_dir (), 'ms' ), self .ms )
143
- if err != None :
143
+ if err is not None :
144
144
return err
145
145
err = write_file (os .path .join (self .sysfs_dir (), 'reset_interval_ms' ),
146
146
self .reset_interval_ms )
147
- if err != None :
147
+ if err is not None :
148
148
return err
149
149
150
150
nr_goals_file = os .path .join (self .sysfs_dir (), 'goals' , 'nr_goals' )
@@ -201,30 +201,30 @@ def sysfs_dir(self):
201
201
202
202
def stage (self ):
203
203
err = write_file (os .path .join (self .sysfs_dir (), 'action' ), self .action )
204
- if err != None :
204
+ if err is not None :
205
205
return err
206
206
err = self .access_pattern .stage ()
207
- if err != None :
207
+ if err is not None :
208
208
return err
209
209
err = write_file (os .path .join (self .sysfs_dir (), 'apply_interval_us' ),
210
210
'%d' % self .apply_interval_us )
211
- if err != None :
211
+ if err is not None :
212
212
return err
213
213
214
214
err = self .quota .stage ()
215
- if err != None :
215
+ if err is not None :
216
216
return err
217
217
218
218
# disable watermarks
219
219
err = write_file (
220
220
os .path .join (self .sysfs_dir (), 'watermarks' , 'metric' ), 'none' )
221
- if err != None :
221
+ if err is not None :
222
222
return err
223
223
224
224
# disable filters
225
225
err = write_file (
226
226
os .path .join (self .sysfs_dir (), 'filters' , 'nr_filters' ), '0' )
227
- if err != None :
227
+ if err is not None :
228
228
return err
229
229
230
230
class DamonTarget :
@@ -243,7 +243,7 @@ def sysfs_dir(self):
243
243
def stage (self ):
244
244
err = write_file (
245
245
os .path .join (self .sysfs_dir (), 'regions' , 'nr_regions' ), '0' )
246
- if err != None :
246
+ if err is not None :
247
247
return err
248
248
return write_file (
249
249
os .path .join (self .sysfs_dir (), 'pid_target' ), self .pid )
@@ -275,27 +275,27 @@ def nr_regions_range_sysfs_dir(self):
275
275
def stage (self ):
276
276
err = write_file (os .path .join (self .interval_sysfs_dir (), 'sample_us' ),
277
277
self .sample_us )
278
- if err != None :
278
+ if err is not None :
279
279
return err
280
280
err = write_file (os .path .join (self .interval_sysfs_dir (), 'aggr_us' ),
281
281
self .aggr_us )
282
- if err != None :
282
+ if err is not None :
283
283
return err
284
284
err = write_file (os .path .join (self .interval_sysfs_dir (), 'update_us' ),
285
285
self .update_us )
286
- if err != None :
286
+ if err is not None :
287
287
return err
288
288
289
289
err = write_file (
290
290
os .path .join (self .nr_regions_range_sysfs_dir (), 'min' ),
291
291
self .min_nr_regions )
292
- if err != None :
292
+ if err is not None :
293
293
return err
294
294
295
295
err = write_file (
296
296
os .path .join (self .nr_regions_range_sysfs_dir (), 'max' ),
297
297
self .max_nr_regions )
298
- if err != None :
298
+ if err is not None :
299
299
return err
300
300
301
301
class DamonCtx :
@@ -329,24 +329,24 @@ def sysfs_dir(self):
329
329
def stage (self ):
330
330
err = write_file (
331
331
os .path .join (self .sysfs_dir (), 'operations' ), self .ops )
332
- if err != None :
332
+ if err is not None :
333
333
return err
334
334
err = self .monitoring_attrs .stage ()
335
- if err != None :
335
+ if err is not None :
336
336
return err
337
337
338
338
nr_targets_file = os .path .join (
339
339
self .sysfs_dir (), 'targets' , 'nr_targets' )
340
340
content , err = read_file (nr_targets_file )
341
- if err != None :
341
+ if err is not None :
342
342
return err
343
343
if int (content ) != len (self .targets ):
344
344
err = write_file (nr_targets_file , '%d' % len (self .targets ))
345
- if err != None :
345
+ if err is not None :
346
346
return err
347
347
for target in self .targets :
348
348
err = target .stage ()
349
- if err != None :
349
+ if err is not None :
350
350
return err
351
351
352
352
nr_schemes_file = os .path .join (
@@ -356,11 +356,11 @@ def stage(self):
356
356
return err
357
357
if int (content ) != len (self .schemes ):
358
358
err = write_file (nr_schemes_file , '%d' % len (self .schemes ))
359
- if err != None :
359
+ if err is not None :
360
360
return err
361
361
for scheme in self .schemes :
362
362
err = scheme .stage ()
363
- if err != None :
363
+ if err is not None :
364
364
return err
365
365
return None
366
366
@@ -384,37 +384,37 @@ def start(self):
384
384
nr_contexts_file = os .path .join (self .sysfs_dir (),
385
385
'contexts' , 'nr_contexts' )
386
386
content , err = read_file (nr_contexts_file )
387
- if err != None :
387
+ if err is not None :
388
388
return err
389
389
if int (content ) != len (self .contexts ):
390
390
err = write_file (nr_contexts_file , '%d' % len (self .contexts ))
391
- if err != None :
391
+ if err is not None :
392
392
return err
393
393
394
394
for context in self .contexts :
395
395
err = context .stage ()
396
- if err != None :
396
+ if err is not None :
397
397
return err
398
398
err = write_file (os .path .join (self .sysfs_dir (), 'state' ), 'on' )
399
399
return err
400
400
401
401
def update_schemes_tried_bytes (self ):
402
402
err = write_file (os .path .join (self .sysfs_dir (), 'state' ),
403
403
'update_schemes_tried_bytes' )
404
- if err != None :
404
+ if err is not None :
405
405
return err
406
406
for context in self .contexts :
407
407
for scheme in context .schemes :
408
408
content , err = read_file (os .path .join (scheme .sysfs_dir (),
409
409
'tried_regions' , 'total_bytes' ))
410
- if err != None :
410
+ if err is not None :
411
411
return err
412
412
scheme .tried_bytes = int (content )
413
413
414
414
def update_schemes_stats (self ):
415
415
err = write_file (os .path .join (self .sysfs_dir (), 'state' ),
416
416
'update_schemes_stats' )
417
- if err != None :
417
+ if err is not None :
418
418
return err
419
419
for context in self .contexts :
420
420
for scheme in context .schemes :
@@ -423,7 +423,7 @@ def update_schemes_stats(self):
423
423
'sz_applied' , 'qt_exceeds' ]:
424
424
content , err = read_file (
425
425
os .path .join (scheme .sysfs_dir (), 'stats' , stat ))
426
- if err != None :
426
+ if err is not None :
427
427
return err
428
428
stat_values .append (int (content ))
429
429
scheme .stats = DamosStats (* stat_values )
@@ -471,10 +471,10 @@ def sysfs_dir(self):
471
471
def start (self ):
472
472
err = write_file (os .path .join (self .sysfs_dir (), 'nr_kdamonds' ),
473
473
'%s' % len (self .kdamonds ))
474
- if err != None :
474
+ if err is not None :
475
475
return err
476
476
for kdamond in self .kdamonds :
477
477
err = kdamond .start ()
478
- if err != None :
478
+ if err is not None :
479
479
return err
480
480
return None
0 commit comments