Skip to content

Commit 067dd58

Browse files
committed
Merge tag 'staging-6.15-rc6' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging
Pull staging driver fixes from Greg KH: "Here are three small staging driver fixes for 6.15-rc6. These are: - bcm2835-camera driver fix - two axis-fifo driver fixes All of these have been in linux-next for a few weeks with no reported issues" * tag 'staging-6.15-rc6' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging: staging: axis-fifo: Remove hardware resets for user errors staging: axis-fifo: Correct handling of tx_fifo_depth for size validation staging: bcm2835-camera: Initialise dev in v4l2_dev
2 parents 914a1fe + c6e8d85 commit 067dd58

File tree

2 files changed

+4
-11
lines changed

2 files changed

+4
-11
lines changed

drivers/staging/axis-fifo/axis-fifo.c

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -393,16 +393,14 @@ static ssize_t axis_fifo_read(struct file *f, char __user *buf,
393393

394394
bytes_available = ioread32(fifo->base_addr + XLLF_RLR_OFFSET);
395395
if (!bytes_available) {
396-
dev_err(fifo->dt_device, "received a packet of length 0 - fifo core will be reset\n");
397-
reset_ip_core(fifo);
396+
dev_err(fifo->dt_device, "received a packet of length 0\n");
398397
ret = -EIO;
399398
goto end_unlock;
400399
}
401400

402401
if (bytes_available > len) {
403-
dev_err(fifo->dt_device, "user read buffer too small (available bytes=%zu user buffer bytes=%zu) - fifo core will be reset\n",
402+
dev_err(fifo->dt_device, "user read buffer too small (available bytes=%zu user buffer bytes=%zu)\n",
404403
bytes_available, len);
405-
reset_ip_core(fifo);
406404
ret = -EINVAL;
407405
goto end_unlock;
408406
}
@@ -411,8 +409,7 @@ static ssize_t axis_fifo_read(struct file *f, char __user *buf,
411409
/* this probably can't happen unless IP
412410
* registers were previously mishandled
413411
*/
414-
dev_err(fifo->dt_device, "received a packet that isn't word-aligned - fifo core will be reset\n");
415-
reset_ip_core(fifo);
412+
dev_err(fifo->dt_device, "received a packet that isn't word-aligned\n");
416413
ret = -EIO;
417414
goto end_unlock;
418415
}
@@ -433,7 +430,6 @@ static ssize_t axis_fifo_read(struct file *f, char __user *buf,
433430

434431
if (copy_to_user(buf + copied * sizeof(u32), tmp_buf,
435432
copy * sizeof(u32))) {
436-
reset_ip_core(fifo);
437433
ret = -EFAULT;
438434
goto end_unlock;
439435
}
@@ -542,7 +538,6 @@ static ssize_t axis_fifo_write(struct file *f, const char __user *buf,
542538

543539
if (copy_from_user(tmp_buf, buf + copied * sizeof(u32),
544540
copy * sizeof(u32))) {
545-
reset_ip_core(fifo);
546541
ret = -EFAULT;
547542
goto end_unlock;
548543
}
@@ -775,9 +770,6 @@ static int axis_fifo_parse_dt(struct axis_fifo *fifo)
775770
goto end;
776771
}
777772

778-
/* IP sets TDFV to fifo depth - 4 so we will do the same */
779-
fifo->tx_fifo_depth -= 4;
780-
781773
ret = get_dts_property(fifo, "xlnx,use-rx-data", &fifo->has_rx_fifo);
782774
if (ret) {
783775
dev_err(fifo->dt_device, "missing xlnx,use-rx-data property\n");

drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1900,6 +1900,7 @@ static int bcm2835_mmal_probe(struct vchiq_device *device)
19001900
__func__, ret);
19011901
goto free_dev;
19021902
}
1903+
dev->v4l2_dev.dev = &device->dev;
19031904

19041905
/* setup v4l controls */
19051906
ret = bcm2835_mmal_init_controls(dev, &dev->ctrl_handler);

0 commit comments

Comments
 (0)