Skip to content

Commit 0506814

Browse files
Justin Teemartinkpetersen
authored andcommitted
scsi: lpfc: Remove unnecessary zero return code assignment in lpfc_sli4_hba_setup
In order to enter the !rc if statement block in question, rc had to have been zero to begin with. Thus, the rc = 0 assignment is unnecessary and can be removed. Signed-off-by: Justin Tee <justin.tee@broadcom.com> Link: https://lore.kernel.org/r/20231009161812.97232-2-justintee8345@gmail.com Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
1 parent 0bb80ec commit 0506814

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

drivers/scsi/lpfc/lpfc_sli.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8571,12 +8571,10 @@ lpfc_sli4_hba_setup(struct lpfc_hba *phba)
85718571
* is not fatal as the driver will use generic values.
85728572
*/
85738573
rc = lpfc_parse_vpd(phba, vpd, vpd_size);
8574-
if (unlikely(!rc)) {
8574+
if (unlikely(!rc))
85758575
lpfc_printf_log(phba, KERN_ERR, LOG_TRACE_EVENT,
85768576
"0377 Error %d parsing vpd. "
85778577
"Using defaults.\n", rc);
8578-
rc = 0;
8579-
}
85808578
kfree(vpd);
85818579

85828580
/* Save information as VPD data */

0 commit comments

Comments
 (0)