Skip to content

Commit 05037e5

Browse files
Kyle MeyerYuryNorov
authored andcommitted
sched/topology: Optimize topology_span_sane()
Optimize topology_span_sane() by removing duplicate comparisons. Since topology_span_sane() is called inside of for_each_cpu(), each previous CPU has already been compared against every other CPU. The current CPU only needs to be compared against higher-numbered CPUs. The total number of comparisons is reduced from N * (N - 1) to N * (N - 1) / 2 on each non-NUMA scheduling domain level. Signed-off-by: Kyle Meyer <kyle.meyer@hpe.com> Reviewed-by: Yury Norov <yury.norov@gmail.com> Acked-by: Vincent Guittot <vincent.guittot@linaro.org> Signed-off-by: Yury Norov <yury.norov@gmail.com>
1 parent 6802f93 commit 05037e5

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

kernel/sched/topology.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2347,7 +2347,7 @@ static struct sched_domain *build_sched_domain(struct sched_domain_topology_leve
23472347
static bool topology_span_sane(struct sched_domain_topology_level *tl,
23482348
const struct cpumask *cpu_map, int cpu)
23492349
{
2350-
int i;
2350+
int i = cpu + 1;
23512351

23522352
/* NUMA levels are allowed to overlap */
23532353
if (tl->flags & SDTL_OVERLAP)
@@ -2359,9 +2359,7 @@ static bool topology_span_sane(struct sched_domain_topology_level *tl,
23592359
* breaking the sched_group lists - i.e. a later get_group() pass
23602360
* breaks the linking done for an earlier span.
23612361
*/
2362-
for_each_cpu(i, cpu_map) {
2363-
if (i == cpu)
2364-
continue;
2362+
for_each_cpu_from(i, cpu_map) {
23652363
/*
23662364
* We should 'and' all those masks with 'cpu_map' to exactly
23672365
* match the topology we're about to build, but that can only

0 commit comments

Comments
 (0)