Skip to content

Commit 02add85

Browse files
committed
KVM: selftests: Reword the NX hugepage test's skip message to be more helpful
Rework the NX hugepage test's skip message regarding the magic token to provide all of the necessary magic, and to very explicitly recommended using the wrapper shell script. Opportunistically remove an overzealous newline; splitting the recommendation message across two lines of ~45 characters makes it much harder to read than running out a single line to 98 characters. Link: https://lore.kernel.org/r/20231129224042.530798-1-seanjc@google.com Signed-off-by: Sean Christopherson <seanjc@google.com>
1 parent 41bccc9 commit 02add85

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

tools/testing/selftests/kvm/x86_64/nx_huge_pages_test.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -257,9 +257,9 @@ int main(int argc, char **argv)
257257
TEST_REQUIRE(kvm_has_cap(KVM_CAP_VM_DISABLE_NX_HUGE_PAGES));
258258

259259
__TEST_REQUIRE(token == MAGIC_TOKEN,
260-
"This test must be run with the magic token %d.\n"
261-
"This is done by nx_huge_pages_test.sh, which\n"
262-
"also handles environment setup for the test.", MAGIC_TOKEN);
260+
"This test must be run with the magic token via '-t %d'.\n"
261+
"Running via nx_huge_pages_test.sh, which also handles "
262+
"environment setup, is strongly recommended.", MAGIC_TOKEN);
263263

264264
run_test(reclaim_period_ms, false, reboot_permissions);
265265
run_test(reclaim_period_ms, true, reboot_permissions);

0 commit comments

Comments
 (0)