Skip to content

Commit 023d4fc

Browse files
committed
Merge tag 'staging-6.12-rc7' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging
Pull staging driver fixes from Greg KH: "Here are two small memory leak fixes for the vchiq_arm staging driver that have been sitting in my tree for weeks and should get merged for 6.12-rc7 so that people don't keep tripping over them. They both have been in linux-next for a while with no reported problems" * tag 'staging-6.12-rc7' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging: staging: vchiq_arm: Use devm_kzalloc() for drv_mgmt allocation staging: vchiq_arm: Use devm_kzalloc() for vchiq_arm_state allocation
2 parents de2f378 + 807babf commit 023d4fc

File tree

1 file changed

+2
-4
lines changed
  • drivers/staging/vc04_services/interface/vchiq_arm

1 file changed

+2
-4
lines changed

drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -593,7 +593,7 @@ vchiq_platform_init_state(struct vchiq_state *state)
593593
{
594594
struct vchiq_arm_state *platform_state;
595595

596-
platform_state = kzalloc(sizeof(*platform_state), GFP_KERNEL);
596+
platform_state = devm_kzalloc(state->dev, sizeof(*platform_state), GFP_KERNEL);
597597
if (!platform_state)
598598
return -ENOMEM;
599599

@@ -1731,7 +1731,7 @@ static int vchiq_probe(struct platform_device *pdev)
17311731
return -ENOENT;
17321732
}
17331733

1734-
mgmt = kzalloc(sizeof(*mgmt), GFP_KERNEL);
1734+
mgmt = devm_kzalloc(&pdev->dev, sizeof(*mgmt), GFP_KERNEL);
17351735
if (!mgmt)
17361736
return -ENOMEM;
17371737

@@ -1789,8 +1789,6 @@ static void vchiq_remove(struct platform_device *pdev)
17891789

17901790
arm_state = vchiq_platform_get_arm_state(&mgmt->state);
17911791
kthread_stop(arm_state->ka_thread);
1792-
1793-
kfree(mgmt);
17941792
}
17951793

17961794
static struct platform_driver vchiq_driver = {

0 commit comments

Comments
 (0)