Skip to content

Commit 0225e10

Browse files
HALIP192kleikamp
authored andcommitted
jfs: validate max amount of blocks before allocation.
The lack of checking bmp->db_max_freebud in extBalloc() can lead to shift out of bounds, so this patch prevents undefined behavior, because bmp->db_max_freebud == -1 only if there is no free space. Signed-off-by: Aleksei Filippov <halip0503@gmail.com> Signed-off-by: Dave Kleikamp <dave.kleikamp@oracle.com> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Reported-and-tested-by: syzbot+5f088f29593e6b4c8db8@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?id=01abadbd6ae6a08b1f1987aa61554c6b3ac19ff2
1 parent 87098a0 commit 0225e10

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

fs/jfs/jfs_extent.c

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -311,6 +311,11 @@ extBalloc(struct inode *ip, s64 hint, s64 * nblocks, s64 * blkno)
311311
* blocks in the map. in that case, we'll start off with the
312312
* maximum free.
313313
*/
314+
315+
/* give up if no space left */
316+
if (bmp->db_maxfreebud == -1)
317+
return -ENOSPC;
318+
314319
max = (s64) 1 << bmp->db_maxfreebud;
315320
if (*nblocks >= max && *nblocks > nbperpage)
316321
nb = nblks = (max > nbperpage) ? max : nbperpage;

0 commit comments

Comments
 (0)