Skip to content

Commit 01105c2

Browse files
zhijianli88martinkpetersen
authored andcommitted
scsi: ibmvscsi_tgt: Convert snprintf() to sysfs_emit()
Per filesystems/sysfs.rst, show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. coccinelle complains that there are still a couple of functions that use snprintf(). Convert them to sysfs_emit(). > ./drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:3619:8-16: WARNING: please use sysfs_emit > ./drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:3625:8-16: WARNING: please use sysfs_emit > ./drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:3633:8-16: WARNING: please use sysfs_emit No functional change intended CC: Michael Cyr <mikecyr@linux.ibm.com> CC: James E.J. Bottomley <jejb@linux.ibm.com> CC: Martin K. Petersen <martin.petersen@oracle.com> CC: linux-scsi@vger.kernel.org CC: target-devel@vger.kernel.org Signed-off-by: Li Zhijian <lizhijian@fujitsu.com> Link: https://lore.kernel.org/r/20240116045151.3940401-24-lizhijian@fujitsu.com Acked-by: Tyrel Datwyler <tyreld@linux.ibm.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
1 parent 29ff822 commit 01105c2

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3616,21 +3616,21 @@ static void ibmvscsis_remove(struct vio_dev *vdev)
36163616
static ssize_t system_id_show(struct device *dev,
36173617
struct device_attribute *attr, char *buf)
36183618
{
3619-
return snprintf(buf, PAGE_SIZE, "%s\n", system_id);
3619+
return sysfs_emit(buf, "%s\n", system_id);
36203620
}
36213621

36223622
static ssize_t partition_number_show(struct device *dev,
36233623
struct device_attribute *attr, char *buf)
36243624
{
3625-
return snprintf(buf, PAGE_SIZE, "%x\n", partition_number);
3625+
return sysfs_emit(buf, "%x\n", partition_number);
36263626
}
36273627

36283628
static ssize_t unit_address_show(struct device *dev,
36293629
struct device_attribute *attr, char *buf)
36303630
{
36313631
struct scsi_info *vscsi = container_of(dev, struct scsi_info, dev);
36323632

3633-
return snprintf(buf, PAGE_SIZE, "%x\n", vscsi->dma_dev->unit_address);
3633+
return sysfs_emit(buf, "%x\n", vscsi->dma_dev->unit_address);
36343634
}
36353635

36363636
static int ibmvscsis_get_system_info(void)

0 commit comments

Comments
 (0)