Skip to content

Commit 007cd6b

Browse files
bvanasschemartinkpetersen
authored andcommitted
scsi: ufs: core: Restore SM8650 support
Some early UFSHCI 4.0 controllers support the UFSHCI 3.0 register set. The UFSHCD_QUIRK_BROKEN_LSDBS_CAP quirk must be set for these controllers. Commit b92e593 ("scsi: ufs: core: Move code out of an if-statement") changed the behavior for these controllers from working fine into "ufshcd_add_scsi_host: failed to initialize (legacy doorbell mode not supported)". Fix this by setting the "broken LSDBS" quirk for the SM8650 development board. Reported-by: Neil Armstrong <neil.armstrong@linaro.org> Closes: https://lore.kernel.org/linux-scsi/0c0bc528-fdc2-4106-bc99-f23ae377f6f5@linaro.org/ Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on SM8650-HDK Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on SM8650-QRD Fixes: b92e593 ("scsi: ufs: core: Move code out of an if-statement") Signed-off-by: Bart Van Assche <bvanassche@acm.org> Link: https://lore.kernel.org/r/20241106181011.4132974-1-bvanassche@acm.org Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
1 parent 50133cf commit 007cd6b

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

drivers/ufs/host/ufs-qcom.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -874,7 +874,8 @@ static void ufs_qcom_advertise_quirks(struct ufs_hba *hba)
874874
if (host->hw_ver.major > 0x3)
875875
hba->quirks |= UFSHCD_QUIRK_REINIT_AFTER_MAX_GEAR_SWITCH;
876876

877-
if (of_device_is_compatible(hba->dev->of_node, "qcom,sm8550-ufshc"))
877+
if (of_device_is_compatible(hba->dev->of_node, "qcom,sm8550-ufshc") ||
878+
of_device_is_compatible(hba->dev->of_node, "qcom,sm8650-ufshc"))
878879
hba->quirks |= UFSHCD_QUIRK_BROKEN_LSDBS_CAP;
879880
}
880881

0 commit comments

Comments
 (0)