Skip to content

Commit 003e6b5

Browse files
Guanghui Fengctmarinas
authored andcommitted
ACPI/IORT: Remove erroneous id_count check in iort_node_get_rmr_info()
According to the ARM IORT specifications DEN 0049 issue E, the "Number of IDs" field in the ID mapping format reports the number of IDs in the mapping range minus one. In iort_node_get_rmr_info(), we erroneously skip ID mappings whose "Number of IDs" equal to 0, resulting in valid mapping nodes with a single ID to map being skipped, which is wrong. Fix iort_node_get_rmr_info() by removing the bogus id_count check. Fixes: 491cf4a ("ACPI/IORT: Add support to retrieve IORT RMR reserved regions") Signed-off-by: Guanghui Feng <guanghuifeng@linux.alibaba.com> Cc: <stable@vger.kernel.org> # 6.0.x Acked-by: Lorenzo Pieralisi <lpieralisi@kernel.org> Tested-by: Hanjun Guo <guohanjun@huawei.com> Link: https://lore.kernel.org/r/1689593625-45213-1-git-send-email-guanghuifeng@linux.alibaba.com Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
1 parent 05d881b commit 003e6b5

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

drivers/acpi/arm64/iort.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1007,9 +1007,6 @@ static void iort_node_get_rmr_info(struct acpi_iort_node *node,
10071007
for (i = 0; i < node->mapping_count; i++, map++) {
10081008
struct acpi_iort_node *parent;
10091009

1010-
if (!map->id_count)
1011-
continue;
1012-
10131010
parent = ACPI_ADD_PTR(struct acpi_iort_node, iort_table,
10141011
map->output_reference);
10151012
if (parent != iommu)

0 commit comments

Comments
 (0)