Skip to content

Commit 84024c8

Browse files
committed
remove internal InstallArgs::dylib_path
1 parent 44e94bc commit 84024c8

File tree

3 files changed

+2
-7
lines changed

3 files changed

+2
-7
lines changed

crates/cargo-gpu/src/args.rs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,10 +42,6 @@ pub struct BuildArgs {
4242
reason = "cmdline args have many bools"
4343
)]
4444
pub struct InstallArgs {
45-
/// path to the `rustc_codegen_spirv` dylib
46-
#[clap(long, hide(true), default_value = "INTERNALLY_SET")]
47-
pub dylib_path: std::path::PathBuf,
48-
4945
/// Directory containing the shader crate to compile.
5046
#[clap(long, default_value = "./")]
5147
pub shader_crate: std::path::PathBuf,

crates/cargo-gpu/src/install.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ package = "rustc_codegen_spirv"
9191

9292
/// Install the binary pair and return the `(dylib_path, toolchain_channel)`.
9393
#[expect(clippy::too_many_lines, reason = "it's fine")]
94-
pub fn run(&mut self) -> anyhow::Result<(PathBuf, String)> {
94+
pub fn run(&self) -> anyhow::Result<(PathBuf, String)> {
9595
// Ensure the cache dir exists
9696
let cache_dir = cache_dir()?;
9797
log::info!("cache directory is '{}'", cache_dir.display());
@@ -210,7 +210,6 @@ package = "rustc_codegen_spirv"
210210
.context("writing target spec files")?;
211211
}
212212

213-
self.spirv_install.dylib_path.clone_from(&dest_dylib_path);
214213
Ok((dest_dylib_path, toolchain_channel))
215214
}
216215
}

crates/cargo-gpu/src/main.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ fn run() -> anyhow::Result<()> {
129129
match cli.command {
130130
Command::Install(install) => {
131131
let shader_crate_path = install.spirv_install.shader_crate;
132-
let mut command =
132+
let command =
133133
config::Config::clap_command_with_cargo_config(&shader_crate_path, env_args)?;
134134
log::debug!(
135135
"installing with final merged arguments: {:#?}",

0 commit comments

Comments
 (0)