Skip to content

Commit c1ed73f

Browse files
committed
Chore: Fix a ton of warnings
1 parent 54978ca commit c1ed73f

24 files changed

+33
-56
lines changed

crates/cudnn/src/activation/activation_descriptor.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
use crate::{sys, ActivationMode, CudnnContext, CudnnError, IntoResult, NanPropagation};
1+
use crate::{sys, ActivationMode, CudnnError, IntoResult, NanPropagation};
22
use std::mem::MaybeUninit;
33

44
/// The descriptor of a neuron activation operation.
@@ -47,7 +47,7 @@ impl ActivationDescriptor {
4747
unsafe {
4848
sys::cudnnCreateActivationDescriptor(raw.as_mut_ptr()).into_result()?;
4949

50-
let mut raw = raw.assume_init();
50+
let raw = raw.assume_init();
5151

5252
let coefficient = coefficient.into().unwrap_or_else(|| match mode {
5353
ActivationMode::ClippedRelu => std::f64::MAX,

crates/cudnn/src/activation/mod.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ use crate::{
88
private, sys, CudnnContext, CudnnError, DataType, IntoResult, ScalingDataType, TensorDescriptor,
99
};
1010
use cust::memory::GpuBuffer;
11-
use std::mem::MaybeUninit;
1211

1312
impl CudnnContext {
1413
/// Applies a specific neuron activation functions element wise of the provided tensor.

crates/cudnn/src/attention/attention_descriptor.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ where
125125
unsafe {
126126
sys::cudnnCreateAttnDescriptor(raw.as_mut_ptr()).into_result()?;
127127

128-
let mut raw = raw.assume_init();
128+
let raw = raw.assume_init();
129129

130130
sys::cudnnSetAttnDescriptor(
131131
raw,

crates/cudnn/src/attention/mod.rs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ pub use attention_weights_kind::*;
88
pub use seq_data_axis::*;
99
pub use seq_data_descriptor::*;
1010

11-
use crate::{sys, CudnnContext, CudnnError, DataType, IntoResult, WGradMode};
11+
use crate::{sys, CudnnContext, CudnnError, IntoResult, WGradMode};
1212
use cust::memory::GpuBuffer;
1313
use std::mem::MaybeUninit;
1414

@@ -259,7 +259,6 @@ impl CudnnContext {
259259
pub fn multi_head_attn_backward_data<T, U, D1, D2>(
260260
&self,
261261
attn_desc: &AttentionDescriptor<T, U, D1, D2>,
262-
current_idx: i32,
263262
lo_win_idx: &[i32],
264263
hi_win_idx: &[i32],
265264
device_seq_lengths_dqdo: &impl GpuBuffer<i32>,
@@ -288,7 +287,7 @@ impl CudnnContext {
288287
let device_seq_lengths_dqdo_ptr =
289288
device_seq_lengths_dqdo.as_device_ptr().as_ptr() as *const _;
290289
let device_seq_lengths_dkdv_ptr =
291-
device_seq_lengths_dqdo.as_device_ptr().as_ptr() as *const _;
290+
device_seq_lengths_dkdv.as_device_ptr().as_ptr() as *const _;
292291

293292
let d_out_ptr = d_out.as_device_ptr().as_ptr() as *const _;
294293

crates/cudnn/src/attention/seq_data_descriptor.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ where
120120
unsafe {
121121
sys::cudnnCreateSeqDataDescriptor(raw.as_mut_ptr()).into_result()?;
122122

123-
let mut raw = raw.assume_init();
123+
let raw = raw.assume_init();
124124

125125
let raw_axes = axes.map(SeqDataAxis::into);
126126

crates/cudnn/src/backend/mod.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
#![allow(warnings)]
2+
13
mod conv_bwd_data;
24
mod conv_bwd_filter;
35
mod conv_cfg;

crates/cudnn/src/context.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
use crate::{sys, CudnnError, IntoResult};
2-
use cust::memory::{GpuBox, GpuBuffer};
3-
use std::mem::{self, MaybeUninit};
2+
use std::mem::MaybeUninit;
43

54
/// cuDNN library context. It's the central structure required to interact with cuDNN.
65
/// It holds and manages internal memory allocations.

crates/cudnn/src/convolution/convolution_algo.rs

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,4 @@
1-
use crate::{
2-
data_type::DataType,
3-
determinism::Determinism,
4-
error::{CudnnError, IntoResult},
5-
math_type::MathType,
6-
private, sys, TensorFormat,
7-
};
1+
use crate::{sys, CudnnError, Determinism, IntoResult, MathType};
82

93
/// The best suited algorithm according to the layer specifications obtained through a heuristic.
104
#[derive(Debug, Clone, Copy, PartialEq)]

crates/cudnn/src/convolution/convolution_config.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
use crate::{private, sys, DataType};
1+
use crate::{private, DataType};
22

33
/// Supported data types configurations for convolution operations.
44
pub trait SupportedConv<X, W, Y>: private::Sealed + DataType

crates/cudnn/src/convolution/convolution_descriptor.rs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
1-
use crate::{
2-
sys, ConvMode, DataType, MathType, TensorFormat, {CudnnError, IntoResult},
3-
};
1+
use crate::{sys, ConvMode, CudnnError, DataType, IntoResult, MathType};
42

53
use std::{marker::PhantomData, mem::MaybeUninit};
64

@@ -97,7 +95,7 @@ impl<T: DataType> ConvDescriptor<T> {
9795
unsafe {
9896
sys::cudnnCreateConvolutionDescriptor(raw.as_mut_ptr()).into_result()?;
9997

100-
let mut conv_desc = Self {
98+
let conv_desc = Self {
10199
raw: raw.assume_init(),
102100
comp_type: PhantomData,
103101
};

0 commit comments

Comments
 (0)