lexer: Improve safety by taking ownership of the tokenized string

CohenArthur · philberty · CohenArthur · commit f7ff6020f8c6 · 2022-03-01T17:20:29.000+01:00
Co-authored-by: philberty &lt;philip.herron@embecosm.com&gt;
diff --git a/gcc/rust/lex/rust-lex.h b/gcc/rust/lex/rust-lex.h
@@ -144,7 +144,7 @@ class Lexer
   /**
    * Lex the contents of a string instead of a file
    */
-  static Lexer lex_string (std::string &input)
+  static Lexer lex_string (std::string input)
   {
     // We can perform this ugly cast to a non-const char* since we're only
     // *reading* the string. This would not be valid if we were doing any

Original file line number	Diff line number	Diff line change
`@@ -144,7 +144,7 @@ class Lexer`
`144`	`144`	`/**`
`145`	`145`	`* Lex the contents of a string instead of a file`
`146`	`146`	`*/`
`147`		`- static Lexer lex_string (std::string &input)`
	`147`	`+ static Lexer lex_string (std::string input)`
`148`	`148`	`{`
`149`	`149`	`// We can perform this ugly cast to a non-const char* since we're only`
`150`	`150`	`// reading the string. This would not be valid if we were doing any`