Skip to content

Commit 3e3c066

Browse files
committed
privacy: visibility: Insert enum/traits and their subitems properly
1 parent cae1e87 commit 3e3c066

File tree

1 file changed

+20
-2
lines changed

1 file changed

+20
-2
lines changed

gcc/rust/privacy/rust-visibility-resolver.cc

Lines changed: 20 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
// <http://www.gnu.org/licenses/>.
1818

1919
#include "rust-visibility-resolver.h"
20+
#include "rust-ast.h"
2021
#include "rust-hir.h"
2122
#include "rust-hir-item.h"
2223

@@ -55,6 +56,7 @@ VisibilityResolver::resolve_visibility (const HIR::Visibility &visibility,
5556
return true;
5657
case HIR::Visibility::PUBLIC:
5758
// FIXME: We need to handle the restricted path here
59+
// FIXME: We also need to handle 2015 vs 2018 edition conflicts
5860
to_resolve = ModuleVisibility::create_public ();
5961
return true;
6062
default:
@@ -116,7 +118,15 @@ VisibilityResolver::visit (HIR::TupleStruct &tuple_struct)
116118

117119
void
118120
VisibilityResolver::visit (HIR::Enum &enum_item)
119-
{}
121+
{
122+
ModuleVisibility vis;
123+
if (!resolve_visibility (enum_item.get_visibility (), vis))
124+
return;
125+
126+
mappings.insert_visibility (enum_item.get_mappings ().get_defid (), vis);
127+
for (auto &variant : enum_item.get_variants ())
128+
mappings.insert_visibility (variant->get_mappings ().get_defid (), vis);
129+
}
120130

121131
void
122132
VisibilityResolver::visit (HIR::Union &union_item)
@@ -132,7 +142,15 @@ VisibilityResolver::visit (HIR::StaticItem &static_item)
132142

133143
void
134144
VisibilityResolver::visit (HIR::Trait &trait)
135-
{}
145+
{
146+
ModuleVisibility vis;
147+
if (!resolve_visibility (trait.get_visibility (), vis))
148+
return;
149+
150+
mappings.insert_visibility (trait.get_mappings ().get_defid (), vis);
151+
for (auto &item : trait.get_trait_items ())
152+
mappings.insert_visibility (item->get_mappings ().get_defid (), vis);
153+
}
136154

137155
void
138156
VisibilityResolver::visit (HIR::ImplBlock &impl)

0 commit comments

Comments
 (0)