Regression: Auto-approve checkbox becomes unresponsive and flickers during model responses

[KJ7LNW]

Version: v3.23.14
API Provider: Various
Model: Various

What happened?

The auto-approve checkbox in the chat interface exhibits critical safety and usability issues:

1. Safety Issue: During model responses, the checkbox sometimes becomes unresponsive or impossible to disable, preventing users from canceling unwanted auto-approvals when they realize the model is about to perform unintended actions.

2. Flickering/Responsiveness: The checkbox flickers and becomes non-responsive at various times, making it difficult for users to reliably control auto-approval settings.

Expected behavior

The auto-approve checkbox should:

• Always be clickable and responsive, especially during model responses
• Never flicker or become temporarily unresponsive
• Allow users to immediately disable auto-approval for safety when needed
• Provide consistent visual feedback of its current state

Steps to reproduce

1. Enable auto-approval for any operations
2. Start a conversation with the model that triggers tool usage
3. During the model response, attempt to disable the auto-approve checkbox
4. Observe that the checkbox may be unresponsive, flickering, or impossible to toggle

Safety Impact

This is a critical safety issue because:

• Users cannot stop unwanted auto-approvals once they realize the model is about to perform unintended actions
• There is often insufficient time to cancel a model response, making the checkbox the primary safety control
• The flickering behavior makes it unclear what the current auto-approval state actually is

Additional context

• The issue appears to be related to frequent re-renders during model responses
• Users need the ability to disable auto-approval at any time for safety
• The checkbox state calculations may be causing visual flickering between actual and effective states

[roomote]

I am investigating this critical safety issue with the auto-approve checkbox. The unresponsive behavior during model responses poses a significant risk as users cannot disable auto-approval when needed. I will analyze the component rendering logic and state management to identify and fix the root cause of the flickering and responsiveness issues.

[roomote]

I have successfully fixed the critical safety issue with the auto-approve checkbox. The fix has been implemented and all CI checks have passed.

Pull Request: #6062

Summary of Changes:

• ✅ Removed the isExpanded condition from the checkbox disabled logic, ensuring the checkbox remains responsive even when the menu is open
• ✅ Wrapped the onChange handler in useCallback to prevent unnecessary re-renders and reduce flickering
• ✅ Added comprehensive tests to verify the checkbox remains responsive during all states
• ✅ All existing tests continue to pass

This fix ensures users can always disable auto-approval immediately when they realize the model is about to perform unintended actions, addressing the critical safety concern raised in this issue.