Skip to content

Commit c6ac1d3

Browse files
applies format and improve fault tolerancy for creation logs on controllers
1 parent e07e1c4 commit c6ac1d3

File tree

4 files changed

+23
-4
lines changed

4 files changed

+23
-4
lines changed

lib/controllers/environment.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,9 +56,14 @@ async def create_env(env: Env) -> Union[EnvCreated, HTTPException]:
5656
else:
5757
return EnvCreated(env_id=env_repo.env_id)
5858
finally:
59+
env_id = (
60+
getattr(env_repo, 'env_id', 'unknown')
61+
if env_repo
62+
else 'unknown'
63+
)
5964
if env_repo:
6065
logger.info(
61-
f"Call to controllers.environment.create_env completed for Env {env_repo.env_id}"
66+
f"Call to controllers.environment.create_env completed for Env {env_id}"
6267
)
6368

6469
@staticmethod

lib/controllers/flight.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,11 @@ async def create_flight(
7373
else:
7474
return FlightCreated(flight_id=flight_repo.flight_id)
7575
finally:
76-
flight_id = getattr(flight_repo, 'flight_id', 'unknown') if flight_repo else 'unknown'
76+
flight_id = (
77+
getattr(flight_repo, 'flight_id', 'unknown')
78+
if flight_repo
79+
else 'unknown'
80+
)
7781
logger.info(
7882
f"Call to controllers.flight.create_flight completed for Flight {flight_id}"
7983
)

lib/controllers/motor.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,9 +69,14 @@ async def create_motor(
6969
else:
7070
return MotorCreated(motor_id=motor_repo.motor_id)
7171
finally:
72+
motor_id = (
73+
getattr(motor_repo, 'motor_id', 'unknown')
74+
if motor_repo
75+
else 'unknown'
76+
)
7277
if motor_repo:
7378
logger.info(
74-
f"Call to controllers.motor.create_motor completed for Motor {motor_repo.motor_id}"
79+
f"Call to controllers.motor.create_motor completed for Motor {motor_id}"
7580
)
7681

7782
@staticmethod

lib/controllers/rocket.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,9 +63,14 @@ async def create_rocket(
6363
else:
6464
return RocketCreated(rocket_id=rocket_repo.rocket_id)
6565
finally:
66+
rocket_id = (
67+
getattr(rocket_repo, 'rocket_id', 'unknown')
68+
if rocket_repo
69+
else 'unknown'
70+
)
6671
if rocket_repo:
6772
logger.info(
68-
f"Call to controllers.rocket.create_rocket completed for Rocket {rocket_repo.rocket_id}"
73+
f"Call to controllers.rocket.create_rocket completed for Rocket {rocket_id}"
6974
)
7075

7176
@staticmethod

0 commit comments

Comments
 (0)